feat: add run-task-capacity-provider-strategy input #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stenlarsson
force-pushed
the
run-task-capacity-provider-strategy
branch
from
2ba4d86
to
635487a
Compare
amazreech
changed the title
|
Hi @stenlarsson, Thank you for making this PR. |
stenlarsson
force-pushed
the
run-task-capacity-provider-strategy
branch
from
635487a
to
7957dbc
Compare
|
@amazreech Thanks for taking a look. I have now fixed the test and rebased the PR. |
omkhegde
approved these changes
Nov 12, 2024
|
Thank you @stenlarsson for your quick response, the tests are passing now. Would you also be able to fix the failing "Package Distribution File" check. For this you would simply need to run |
amazreech
approved these changes
Nov 12, 2024
stenlarsson
force-pushed
the
run-task-capacity-provider-strategy
branch
from
7957dbc
to
a5ebbd5
Compare
|
Ok, done |
When you use cluster auto scaling, you must specify `capacityProviderStrategy` and not `launchType`. Unfortunately this is not possible to configure when running a one-off task with this action. This adds a new input `run-task-capacity-provider-strategy` which takes a JSON array of capacity provider strategy items. When this is specified, `run-task-launch-type` will not be applied.
stenlarsson
force-pushed
the
run-task-capacity-provider-strategy
branch
from
a5ebbd5
to
34b5d6b
Compare
|
I must have used the wrong version of something when running that command. Let's try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use cluster auto scaling, you must specify
capacityProviderStrategyand notlaunchType(as mentioned in the RunTask documentation). Unfortunately this is currently not possible to configure when running a one-off task with this action.Issue #, if available:
None
Description of changes:
This adds a new input
run-task-capacity-provider-strategywhich takes a JSON array of capacity provider strategy items. When this is specified,run-task-launch-typewill not be applied.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.