Support ARN being passed in as well as a file #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amazreech
reviewed
Nov 11, 2024
| let taskDefArn = null; | ||
|
|
||
| // Of taskDefContent starts with arn: then we assume it is a task definition ARN | ||
| if (taskDefinitionContent.startsWith("arn:")) { |
There was a problem hiding this comment.
Thank you for this PR!
I am wondering if it would be a good idea to introduce another variable for taskDefinitionArn instead of re-using existing variable? This could ease error handling by helping us return proper error messages back to users.
We have something similar implemented in the amazon-ecs-render-task-definition repo as well:
https://github.com/aws-actions/amazon-ecs-render-task-definition/blob/master/dist/index.js#L32
There was a problem hiding this comment.
Okay, I will implement it in the equivalent way to the render task definition action.
|
@LukeSheard Thanks for taking the initiative, it would be great to get this change merged 💪 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An up to date version of this PR which should support the AWS SDK v3.