Move the C coverage to the CodeCov GitHub Action #3947
Conversation
Same as Last PR. Now I expect the Lua coverage to work and the C coverage. I did it in 2 PRs to make sure the delta works. I also added a `-j8` in the example test step because it is I/O bound and it has enough ram. This should speed-up the CI (maybe?).
|
Documentation has been updated for this PR. Compare view: awesomeWM/apidoc@adf4661...31233a7 |
Last commit message: Merge 525db87185d68e722c32658f0bf045bae927ead5 into 7034db3a446d61327305f5fef7d4d908804724a3 Commits: Build URL: https://github.com/awesomeWM/awesome/actions/runs/10548445802 Pull request: awesomeWM/awesome#3947
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3947 +/- ##
===========================================
- Coverage 91.26% 48.52% -42.74%
===========================================
Files 936 195 -741
Lines 60147 22424 -37723
===========================================
- Hits 54894 10882 -44012
- Misses 5253 11542 +6289
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Documentation has been updated for this PR. Compare view: awesomeWM/apidoc@adf4661...fcf11ac |
|
Documentation has been updated for this PR. Compare view: awesomeWM/apidoc@adf4661...bf094e6 |
.github/workflows/main.yml
Outdated
| @@ -308,7 +304,7 @@ jobs: | |||
| run: cd "${{ github.workspace }}/build" && make check-unit | |||
|
|
|||
| - name: Run examples tests | |||
| run: cd "${{ github.workspace }}/build" && make check-examples | |||
| run: cd "${{ github.workspace }}/build" && make check-examples -j16 | |||
There was a problem hiding this comment.
shouldn't it be -j$(nproc) ?
There was a problem hiding this comment.
No, the examples tests are not CPU bound, they are I/O bound. For example, I use -j99 on my 16 thread desktop and it's 4x faster than -j17. As long as it doesn't take more ram than the VM has, the larger the number is, the faster it goes.
There was a problem hiding this comment.
Maybe add a comment with this explanation?
|
Documentation has been updated for this PR. Compare view: awesomeWM/apidoc@bfbd86f...c77af50 |
|
Documentation has been updated for this PR. Compare view: awesomeWM/apidoc@bfbd86f...e5b8bb6 |
|
Documentation has been updated for this PR. Compare view: awesomeWM/apidoc@bfbd86f...6d344c1 |
Same as Last PR. Now I expect the Lua coverage to work and the C coverage. I did it in 2 PRs to make sure the delta works.
I also added a
-j16in the example test step because it is I/O bound and it has enough ram. This should speed-up the CI (maybe?).Fix #3934