Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a drawin crash, a drawin memory leak and a wallpaper error. #3880

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Dec 30, 2023

  1. drawable: Fix a regression from awful.wallpaper.

    It is possible for that variable to not be set if `awful` was
    never loaded.
    Elv13 committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    9a3b6fe View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2023

  1. wibox: Fix __to_string and garbage collection.

    There was no "real" unsolvable GC issues, but at least for Lua
    5.2 and 5.3, it wasn't possible to GC a wibox anymore. This
    commit unwind the circular references with 3 new weak refs. This
    is enough to get a specific test to pass on Lua 5.3. It's voodoo,
    but this was actually a pretty bad leak. There's other according
    to some test I wrote, but that's one.
    
    As for to_string, it appears to be accidental refactoring oversight.
    Elv13 committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    16b92a0 View commit details
    Browse the repository at this point in the history
  2. drawin: Fix a segfault.

    When a drawable has a pending redraw in a delayed call and the
    drawin is GCed (which was impossible because it was broken
    until the last commit), it crashes.
    Elv13 committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    ff299d9 View commit details
    Browse the repository at this point in the history
  3. tests: Add semi commented tests for wibox garbage collection.

    When you run this outside of the test runner, it works, but not
    with it. Anyway, it adds the regression tests for the previous
    crash, so it's worth having.
    Elv13 committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    3fa9c66 View commit details
    Browse the repository at this point in the history