Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #4424][REST] Catch No Node Exception, when list kyuubi engines #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

yanghua
Copy link

@yanghua yanghua commented Apr 13, 2023

Why are the changes needed?

Close apache#4424

Catch No Node Exception, when list kyuubi engines

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

WX20230227-184957

Closes apache#4425 from zwangsheng/kyuubi-4424.

Closes apache#4424

3052b15 [zwangsheng] [Kyuubi apache#4424] Fix scala style 74825cf [zwangsheng] [Kyuubi apache#4424] Throw User Friendly Exception 7e8363c [zwangsheng] [Kyuubi apache#4424] Remove usless file & catch subException 4a3c469 [zwangsheng] [Kyuubi apache#4424] Catch cacth No Node Exception, when list kyuubi engines

Authored-by: zwangsheng 2213335496@qq.com

Why are the changes needed?

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

…engines

### _Why are the changes needed?_

Close apache#4424

Catch No Node Exception, when list kyuubi engines

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

![WX20230227-184957](https://user-images.githubusercontent.com/52876270/221544376-2f0d6b4b-0bc4-446e-abb1-d0c79211aea4.png)

Closes apache#4425 from zwangsheng/kyuubi-4424.

Closes apache#4424

3052b15 [zwangsheng] [Kyuubi apache#4424] Fix scala style
74825cf [zwangsheng] [Kyuubi apache#4424] Throw User Friendly Exception
7e8363c [zwangsheng] [Kyuubi apache#4424] Remove usless file & catch subException
4a3c469 [zwangsheng] [Kyuubi apache#4424] Catch cacth No Node Exception, when list kyuubi engines

Authored-by: zwangsheng <2213335496@qq.com>
Signed-off-by: ulyssesyou <ulyssesyou@apache.org>
@yanghua yanghua force-pushed the awesome-kyuubi-master-cherry-pick branch from 76378a3 to 5ab2efa Compare April 13, 2023 09:23
Signed-off-by: yanghua <yanghua1127@gmail.com>
@yanghua yanghua closed this Apr 14, 2023
@yanghua yanghua reopened this Apr 14, 2023
Signed-off-by: yanghua <yanghua1127@gmail.com>
@yanghua yanghua closed this Apr 14, 2023
@yanghua yanghua reopened this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [REST] Should cacth NoNode Exception instead of throw, when list kyuubi engines
2 participants