103.next LTS backports #5953
Draft
103.next LTS backports #5953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tmpfile.mktemp function for creating tmp files has been depraceted since 2.3 and has security issues. Lets remove it and use tmpdir instead. Reference: https://github.com/avocado-framework/avocado/security/code-scanning/278 Signed-off-by: Jan Richter <jarichte@redhat.com>
This commit adds error handling to TaskStatusService. When the connection is lost, it will try to establish a new connection. If the connection is not possible to renew, the task will send warning message about new status and remove TaskStatusService from available services. Reference: avocado-framework#5794 Signed-off-by: Jan Richter <jarichte@redhat.com> Signed-off-by: Cleber Rosa <crosa@redhat.com>
This commit will move establishment of status service connection from post method to its own dedicated method. Thanks to this change, it will be possible to establish connection over again when a problem occurs. Signed-off-by: Jan Richter <jarichte@redhat.com>
When creating Runnables from recipes, the given configuration will get discarded when "filtering" the configuration used. The correct approach is to keep the given configuration, and suplement it with the other needed (used) configuration. Signed-off-by: Cleber Rosa <crosa@redhat.com>
This creates a Dependency class to make dependencies hashable. Thanks to this change, we can easily find duplicates and remove them. This change is really necessary for Job dependencies, where the duplicates can be easily created by adding the same dependency to a test and job. Signed-off-by: Jan Richter <jarichte@redhat.com> Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
103lts_06_11_24_backports
branch
from
b9d7ca4
to
e5bed0e
Compare
|
Are these back-ports due any soon, and would love to see PR related to discussion #5610 to be also back-ported too. Any updates on that would be very much appreciated |
Hi @arif-ali, I'll look into including those. We managed to release 106.0 last week, so I have more resources to push this through now. Best! |
The store_logging_stream_external test installs external package matplotlib and checks with the package properly logs to the avocado directories. Unfortunately, this test used hardcoded line number of matplotlib. Because of this, the test started failing when the line was changed. This commit fixes this test by using regex instead of hardcoded string. After this change, the test should be protected against external changes in matplotlib package. Signed-off-by: Jan Richter <jarichte@redhat.com>
On Python 3.12.2 and later the message given when no tests are run was reverted to the pre-3.12.1 era. Sigh. Let's adapt the nrunner selftest to take that into consideration. Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
103lts_06_11_24_backports
branch
from
1941bd5
to
6514855
Compare
The container image used in CI for the static checks now has black installed from pip. This means that the executable "black" may not be always accessible, but using "python3 -m" as an entrypoint is. This is a partial backport of 77ca585. Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
103lts_06_11_24_backports
branch
from
6514855
to
725cf09
Compare
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Fedora 38 is the development image used on CI, and one that is popular for Avocado development at this time. Let's match the version of psutil available on the distro with the development requirement. This avoid the atempt to compile a custom version of psutil. Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
103lts_06_11_24_backports
branch
from
725cf09
to
42365c5
Compare
There's value in making the zstd probe function public (which was previously not perceived). This function can be used to skip/cancel tests when a suitable zstd is not found. Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
103lts_06_11_24_backports
branch
from
42365c5
to
f19efec
Compare
This adds markupsafe<3.0.0 requirements to html plugin, because markupsafe-3.0.0 can't be installed with older versions of setuptools on RHEL9 and other systems because of `CCompilerError`. We need to add the same requirement to `ansible` plugin, because it would try to install markupsafe-3.0.0 Reference: avocado-framework#6038 Signed-off-by: Jan Richter <jarichte@redhat.com>
This fixes two problems with the current version parse mechanism:
1. Recent setuptools' version parse function, which has dropped
"LegacyVersion" support, raises an InvalidVersion exception
for common kernel version info as presented by the system and
returned by os.uname()
2. The import of the packaging module is broken on systems with no
setuptools and only the "packaging" module.
This introduces a simple but custom version parse that solves both and
simplifies dependencies.
Fixes: avocado-framework#6058
Signed-off-by: Cleber Rosa <crosa@redhat.com>
PyYAML versions 6.0.0 and later, are not compatible with Python 3.7. Let's drop the minimal version requirement, which is not needed on current platforms while setting the maximum version to avoid Python 3.7 incompatibilities. Reference: https://pypi.org/project/PyYAML/5.4.1/ Signed-off-by: Cleber Rosa <crosa@redhat.com>
The number based naming of the job-api related suites do not provide clear information on what it is about. This uses a more meaningful name for them. Signed-off-by: Cleber Rosa <crosa@redhat.com>
…mits The sqlite3 module (and actually, even the non-python binary with the same name), have "interesting" limitations when it comes to the database path. When the test that creates the journal file, and checks for it, runs as part of an RPM build, the extra directories (/buildir/...) exceed the path size limit. While it would be possible to check if the "logdir" path, plus the name of the journal database path, would eventually exceed the sqlite3 limits, this logic would be exclusive for one test variant. IMO it does not justify adding such logic to keep a test that has considerably low value. Signed-off-by: Cleber Rosa <crosa@redhat.com>
During RPM builds on Fedora 42 (really rawhide at this time), the RPM package dependency system provides MarkupSafe > 3.0.0 (currently 3.0.2). So, we remove the pinning, or else, the build would fail due to a version requirement conflict. Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
103lts_06_11_24_backports
branch
from
12b9281
to
8f006bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of bugfixes that do not change the behavior (besides fixing/improving the specific condition) that come from Avocado versions > 103.x.