Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide image specific parameters for each QemuImg instance #3515

Closed
wants to merge 1 commit into from

Conversation

pevogam
Copy link
Contributor

@pevogam pevogam commented Sep 8, 2022

These are necessary for vms with multiple images and other cases where we would like to manipulate specific image and/or its snapshot.

Signed-off-by: Plamen Dimitrov plamen.dimitrov@intra2net.com

These are necessary for vms with multiple images and other cases
where we would like to manipulate specific image and/or its snapshot.

Signed-off-by: Plamen Dimitrov <plamen.dimitrov@intra2net.com>
@pevogam
Copy link
Contributor Author

pevogam commented Sep 8, 2022

@luckyh @YongxueHong: I have a few more incoming PR-s regarding the qemu-img functionality that I am wondering whether to push now all at once or to wait for this and PR #3495 to be merged first. What do you think?

@pevogam
Copy link
Contributor Author

pevogam commented Sep 8, 2022

An example on how the above change is useful:

Type "help", "copyright", "credits" or "license" for more information.
>>> from virttest.utils_params import Params
>>> from virttest.qemu_storage import QemuImg
>>>
>>> image = "image1"
>>> state = "on_customize"
>>>
>>> params = Params()
>>> params["image_chain"] = f"snapshot {image}"
>>> params["image_name_snapshot"] = state
>>> params["image_format_snapshot"] = "qcow2"
>>> params["images_base_dir"] = "loc"
>>> params["image_name_image1"] = "test"
>>>
>>> qemu_img = QemuImg(params, params["images_base_dir"], "image1")
>>> qemu_img.image_filename
'loc/test.qcow2'
>>>
>>> qemu_img = QemuImg(params, params["images_base_dir"], "snapshot")
>>> qemu_img.image_filename
'loc/on_customize.qcow2'

@pevogam
Copy link
Contributor Author

pevogam commented Sep 9, 2022

Alright, in interest of saving time I would go ahead with all remaining pull requests:

And the somewhat less related:

I would really appreciate if anyone of you could take a look or suggest a maintainer that is responsible and/or knowledgeable about these areas of the code base. Thanks!

@luckyh
Copy link
Contributor

luckyh commented Sep 15, 2022

Alright, in interest of saving time I would go ahead with all remaining pull requests:

* [Wait for proper monitor status before sending cont to monitor #3518](https://github.com/avocado-framework/avocado-vt/pull/3518)

* [Do not resume but verify paused status #3519](https://github.com/avocado-framework/avocado-vt/pull/3519)

* [Add timeout and allow space containing paths for "qemu-img convert" #3521](https://github.com/avocado-framework/avocado-vt/pull/3521)

And the somewhat less related:

* [Make background errors nonfatal as they often register unrelated events #3520](https://github.com/avocado-framework/avocado-vt/pull/3520)

I would really appreciate if anyone of you could take a look or suggest a maintainer that is responsible and/or knowledgeable about these areas of the code base. Thanks!

OK, I'll take a look on the above ones in the next couple weeks, thanks.

@pevogam
Copy link
Contributor Author

pevogam commented Nov 14, 2022

@luckyh @YongxueHong: I have a few more incoming PR-s regarding the qemu-img functionality that I am wondering whether to push now all at once or to wait for this and PR #3495 to be merged first. What do you think?

Just to clarify, this pull request is not blocked by any other above, they are simply independent pull requests that followed this one.

@pevogam
Copy link
Contributor Author

pevogam commented Dec 5, 2022

@YongxueHong Would you mind sharing your opinion here?

@pevogam pevogam closed this Dec 13, 2022
@pevogam pevogam deleted the qemu-img-params branch August 27, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants