Package ppc64-diag is now a part of Appstream not baseOS. #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppc64-diag is now splitted in two parts, ppc64-diag-rtas as part of baseOS and ppc-64-diag as part of Appstream. Signed-off-by: Krishan Gopal Saraswat <krishang@linux.ibm.com>
|
@Krishan-Saraswat we need both packages right? |
Naresh-ibm
reviewed
Oct 4, 2024
| @@ -27,7 +27,7 @@ def setUp(self): | |||
|
|
|||
| self.sm = SoftwareManager() | |||
| self.packages = self.params.get( | |||
| 'packages', default=['powerpc-utils', 'ppc64-diag', 'lsvpd']) | |||
| 'packages', default=['powerpc-utils', 'ppc64-diag-rtas', 'lsvpd']) | |||
There was a problem hiding this comment.
@Krishan-Saraswat why are we adding the default packages again here?
your hard coding them in yaml. I feel they are needed again as default packages.
Please move them either to .py file as we have other testcases, or take support of yaml file
There was a problem hiding this comment.
@Krishan-Saraswat if I understand correctly, ppc64-diag split in two package one is ppc64-diag and other is ppc64-diag-rtas and ppc64-diag is no more default package ?
There was a problem hiding this comment.
If this correct this will be applicable only for the latest distro then we should still have support for the old distro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ppc64-diag is now splitted in two parts, ppc64-diag-rtas as part of baseOS and ppc-64-diag as part of Appstream.
[root@ltcrain8oj-lp7 ras]# avocado run --max-parallel-tasks=1 packages.py
JOB ID : 774721c03c73d98867248051824a9d57d28197a1
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-10-03T23.38-774721c/job.log
(1/1) packages.py:Package_check.test: STARTED
(1/1) packages.py:Package_check.test: PASS (0.27 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-10-03T23.38-774721c/results.html
JOB TIME : 15.67 s
[root@ltcrain8oj-lp7 ras]# rpm -qa ppc64-diag*
ppc64-diag-rtas-2.7.9-7.el10.ppc64le