Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the different python3-devel package names in RHEL8 and RHEL9 #2873

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PavamanSubramaniyam
Copy link
Contributor

So handling the different package names available to be installed accordingly

So handling the different package names available to be installed accordingly

Signed-off-by: Pavaman Subramaniyam <pavsubra@linux.vnet.ibm.com>
@PavamanSubramaniyam
Copy link
Contributor Author

Below is the result of the MOFED ISO installation on RHEL8.10 OS.

avocado run --max-parallel-tasks=1 mofed_install_test.py -m mofed_install_test.py.data/mofed_install_test.yaml
Fetching asset from mofed_install_test.py:MOFEDInstallTest.test
Fetching asset from mofed_install_test.py:MOFEDInstallTest.test
JOB ID : 30aa8376225cadd298710aa476205fe06f54ec25
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-08-09T00.31-30aa837/job.log
(1/1) mofed_install_test.py:MOFEDInstallTest.test;run-Options-add-kernel-support-Parameters-84c5: STARTED
Initializing...
Attempting to perform Firmware update...
Querying Mellanox devices firmware ...

Device #1:

Device Type: ConnectX6DX
Part Number: 02CM941_Ax
Description: 2-Port 100GbE PCIe 4.0X16 RoCE Network Adapter
PSID: IBM0000000037
PCI Device Name: 0014:01:00.0
Base GUID: 043f720300a93728
Base MAC: 043f72a93728
Versions: Current Available
FW 22.41.1000 22.41.1000
FCODE N/A 0.0.0400

Status: Up to date

Log File: /tmp/PwI0h4No_O
Real log file: /tmp/MLNX_OFED_LINUX.432162.logs/fw_update.log
(1/1) mofed_install_test.py:MOFEDInstallTest.test;run-Options-add-kernel-support-Parameters-84c5: PASS (666.94 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-08-09T00.31-30aa837/results.html
JOB TIME : 670.34 s

@PavamanSubramaniyam
Copy link
Contributor Author

Below is the result of the MOFED ISO installation on RHEL9.2 OS.

avocado run --max-parallel-tasks=1 mofed_install_test.py -m mofed_install_test.py.data/mofed_install_test.yaml
Fetching asset from mofed_install_test.py:MOFEDInstallTest.test
Fetching asset from mofed_install_test.py:MOFEDInstallTest.test
JOB ID : e36bc298c146a34986cf708d8c1cb7b130b936b3
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-08-07T06.08-e36bc29/job.log
(1/1) mofed_install_test.py:MOFEDInstallTest.test;run-Options-add-kernel-support-Parameters-d49d: STARTED
(1/1) mofed_install_test.py:MOFEDInstallTest.test;run-Options-add-kernel-support-Parameters-d49d: PASS (808.72 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-08-07T06.08-e36bc29/results.html
JOB TIME : 833.15 s

@abdhaleegit abdhaleegit self-assigned this Aug 26, 2024
@abdhaleegit abdhaleegit self-requested a review August 26, 2024 13:05
"kernel-rpm-macros", "gdb-headless", "rpm-build",
"gcc-gfortran", kernel_ver])
if detected_distro.version == "9":
pkgs.extend(["make", "gcc", "python3-devel", "tcsh",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of duplicating all package names you can restrict the if else only for python3/python36 package

        pkgs.extend(["make", "gcc", "tcsh",
                     "kernel-rpm-macros", "gdb-headless", "rpm-build",
                     "gcc-gfortran", kernel_ver])
        if detected_distro.version == "9":
            pkgs.extend(["python3-devel"])
        elif detected_distro.version == "8":
            pkgs.extend(["python36-devel"])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants