Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting to peer session in between test #2864

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vaishnavibhat
Copy link
Contributor

The patch connects to the peer session after doing a cleanup. In few of the runs, the connection to peer session is disrupted after doing a rm of htx files.

The patch connects to the peer session after doing a cleanup.
In few of the runs, the connection to peer session is disrupted
after doing a rm of htx files.

Signed-off-by: Vaishnavi Bhat <vaishnavi@linux.vnet.ibm.com>
@vaishnavibhat
Copy link
Contributor Author

The prompt is requesting for password in between the test as below. The patch fixes this problem.

avocado run htx_nic_devices.py:HtxNicTest.test_start -m htx_nic_devices.py.data/htx_nic_devices.yaml
JOB ID : fc47feca225cc6df65fc691dc8b9e1dca604ba2a
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-08-02T03.12-fc47fec/job.log
(1/1) htx_nic_devices.py:HtxNicTest.test_start;run-a8b2: STARTED
Password:
(1/1) htx_nic_devices.py:HtxNicTest.test_start;run-a8b2: INTERRUPTED: Test interrupted: Interrupted by user (568.15 s)

RESULTS : PASS 0 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 1 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-08-02T03.12-fc47fec/results.html
JOB TIME : 583.52 s

After patch:

avocado run htx_nic_devices.py:HtxNicTest.test_start -m htx_nic_devices.py.data/htx_nic_devices.yaml
JOB ID : 7272a3e39a476f10d2cb606ecb777a491532f0e0
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-08-02T03.29-7272a3e/job.log
(1/1) htx_nic_devices.py:HtxNicTest.test_start;run-a8b2: STARTED
(1/1) htx_nic_devices.py:HtxNicTest.test_start;run-a8b2: PASS (177.30 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-08-02T03.29-7272a3e/results.html
JOB TIME : 193.98 s

#avocado list htx_nic_devices.py
avocado-instrumented htx_nic_devices.py:HtxNicTest.test_start
avocado-instrumented htx_nic_devices.py:HtxNicTest.test_check
avocado-instrumented htx_nic_devices.py:HtxNicTest.test_stop
ltcden7-lp22-new:~/avocado-fvt-wrapper/tests/avocado-misc-tests/io/net # avocado run htx_nic_devices.py:HtxNicTest.test_check -m htx_nic_devices.py.data/htx_nic_devices.yaml
JOB ID : ac79d74183f1863dc978265382c500600f7a6d34
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-08-02T03.40-ac79d74/job.log
(1/1) htx_nic_devices.py:HtxNicTest.test_check;run-a8b2: STARTED
(1/1) htx_nic_devices.py:HtxNicTest.test_check;run-a8b2: PASS (128.26 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-08-02T03.40-ac79d74/results.html
JOB TIME : 146.64 s

#avocado run htx_nic_devices.py:HtxNicTest.test_stop -m htx_nic_devices.py.data/htx_nic_devices.yaml
JOB ID : a1ace3acdd35af98ed335461acfa280ab5e35f79
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-08-02T03.43-a1ace3a/job.log
(1/1) htx_nic_devices.py:HtxNicTest.test_stop;run-a8b2: STARTED
(1/1) htx_nic_devices.py:HtxNicTest.test_stop;run-a8b2: PASS (9.79 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-08-02T03.43-a1ace3a/results.html
JOB TIME : 28.42 s

avocado run htx_nic_devices.py -m htx_nic_devices.py.data/htx_nic_devices.yaml --max-parallel-tasks=1
JOB ID : adb2438014b3c6e685e794b8809ced8dce765e89
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-08-02T05.04-adb2438/job.log
(1/3) htx_nic_devices.py:HtxNicTest.test_start;run-a8b2: STARTED
(1/3) htx_nic_devices.py:HtxNicTest.test_start;run-a8b2: PASS (152.98 s)
(2/3) htx_nic_devices.py:HtxNicTest.test_check;run-a8b2: STARTED
(2/3) htx_nic_devices.py:HtxNicTest.test_check;run-a8b2: PASS (124.64 s)
(3/3) htx_nic_devices.py:HtxNicTest.test_stop;run-a8b2: STARTED
(3/3) htx_nic_devices.py:HtxNicTest.test_stop;run-a8b2: PASS (9.32 s)
RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-08-02T05.04-adb2438/results.html
JOB TIME : 308.54 s

Uploading job.log…

@PraveenPenguin
Copy link
Member

@abdhaleegit @FarooqAbdulla01 can any one of you please review this PR

@abdhaleegit abdhaleegit self-assigned this Aug 5, 2024
@abdhaleegit abdhaleegit self-requested a review August 5, 2024 09:06
@abdhaleegit
Copy link
Collaborator

@vaishnavibhat So is this because of this ?

 if os.path.exists('/usr/lpp/htx'):
                    shutil.rmtree('/usr/lpp/htx')
            self.log.info("Deleted old htx rpm packages from host")

Copy link
Collaborator

@Naresh-ibm Naresh-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaishnavibhat
Copy link
Contributor Author

@vaishnavibhat So is this because of this ?

 if os.path.exists('/usr/lpp/htx'):
                    shutil.rmtree('/usr/lpp/htx')
            self.log.info("Deleted old htx rpm packages from host")

The issue should not be because of this, as its clearing only files uner /usr/lpp/htx .. But I am seeing the files under .ssh being removed too,
The issue is not seeing with every run .

@@ -189,6 +189,8 @@ def build_htx(self):
if host_distro_pattern == peer_distro_pattern:
if process.system(cmd, shell=True, ignore_status=True):
self.cancel("Installion of rpm failed")
if not self.session.connect():
self.cancel("failed connecting to peer")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if no connection.. should not you connect the session instead of failing ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaishnavibhat any update here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants