-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connecting to peer session in between test #2864
base: master
Are you sure you want to change the base?
Connecting to peer session in between test #2864
Conversation
The patch connects to the peer session after doing a cleanup. In few of the runs, the connection to peer session is disrupted after doing a rm of htx files. Signed-off-by: Vaishnavi Bhat <vaishnavi@linux.vnet.ibm.com>
The prompt is requesting for password in between the test as below. The patch fixes this problem. avocado run htx_nic_devices.py:HtxNicTest.test_start -m htx_nic_devices.py.data/htx_nic_devices.yaml RESULTS : PASS 0 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 1 | CANCEL 0 After patch: avocado run htx_nic_devices.py:HtxNicTest.test_start -m htx_nic_devices.py.data/htx_nic_devices.yaml #avocado run htx_nic_devices.py:HtxNicTest.test_stop -m htx_nic_devices.py.data/htx_nic_devices.yaml avocado run htx_nic_devices.py -m htx_nic_devices.py.data/htx_nic_devices.yaml --max-parallel-tasks=1 |
@abdhaleegit @FarooqAbdulla01 can any one of you please review this PR |
@vaishnavibhat So is this because of this ?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The issue should not be because of this, as its clearing only files uner /usr/lpp/htx .. But I am seeing the files under .ssh being removed too, |
@@ -189,6 +189,8 @@ def build_htx(self): | |||
if host_distro_pattern == peer_distro_pattern: | |||
if process.system(cmd, shell=True, ignore_status=True): | |||
self.cancel("Installion of rpm failed") | |||
if not self.session.connect(): | |||
self.cancel("failed connecting to peer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if no connection.. should not you connect the session instead of failing ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vaishnavibhat any update here?
The patch connects to the peer session after doing a cleanup. In few of the runs, the connection to peer session is disrupted after doing a rm of htx files.