Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read_dawr_perf_interface #2772

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

read_dawr_perf_interface #2772

wants to merge 1 commit into from

Conversation

akanksha216
Copy link
Contributor

Add new test cases for reading single DAWR register and multiple DAWR registers with perf interface

Logs:

avocado run dawr.py

JOB ID : 67f293450d9feb4166168645c1fd77573d6b75bb
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-03-15T16.16-67f2934/job.log
(2/5) dawr.py:Dawr.test_read_dawr_v2_gdb: STARTED
(1/5) dawr.py:Dawr.test_read_dawr_v1_gdb: STARTED
(3/5) dawr.py:Dawr.test_read_dawr_v3_gdb: STARTED
(4/5) dawr.py:Dawr.test_read_dawr_v1_perf: STARTED
(1/5) dawr.py:Dawr.test_read_dawr_v1_gdb: PASS (1.95 s)
(3/5) dawr.py:Dawr.test_read_dawr_v3_gdb: PASS (2.03 s)
(4/5) dawr.py:Dawr.test_read_dawr_v1_perf: PASS (2.34 s)
(5/5) dawr.py:Dawr.test_read_dawr_v2_perf: STARTED
(5/5) dawr.py:Dawr.test_read_dawr_v2_perf: PASS (2.06 s)
(2/5) dawr.py:Dawr.test_read_dawr_v2_gdb: PASS (32.23 s)
RESULTS : PASS 5 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-03-15T16.16-67f2934/results.html
JOB TIME : 60.49 s

test_read_dawr_v1_perf.log
test_read_dawr_v2_perf.log

PraveenPenguin
PraveenPenguin reviewed Mar 19, 2024
View reviewed changes
trace/dawr.py Outdated
@@ -18,8 +18,9 @@
import os
import shutil
import pexpect
import platform
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems this not used any where can you please remove

@sacsant
Copy link
Contributor

sacsant commented Apr 11, 2024

@akanksha216 seems like there is some white space damage with the code you submitted. If I clone read_dawr_perf_interface branch and try to run the test I get

~ avocado run --max-parallel-tasks=1 trace/dawr.py
No tests found for given test references: trace/dawr.py
Try 'avocado -V list trace/dawr.py' for details

Pycodestyle reports several errors

pycodestyle dawr.py
dawr.py:56:1: E101 indentation contains mixed spaces and tabs
dawr.py:56:1: W191 indentation contains tabs
dawr.py:58:1: E101 indentation contains mixed spaces and tabs
dawr.py:78:1: E101 indentation contains mixed spaces and tabs
dawr.py:78:1: W191 indentation contains tabs
dawr.py:79:1: E101 indentation contains mixed spaces and tabs
dawr.py:84:1: E101 indentation contains mixed spaces and tabs
dawr.py:84:1: W191 indentation contains tabs
dawr.py:85:1: E101 indentation contains mixed spaces and tabs
dawr.py:148:80: E501 line too long (82 > 79 characters)
dawr.py:154:1: E101 indentation contains mixed spaces and tabs
dawr.py:154:1: W191 indentation contains tabs
dawr.py:155:1: E101 indentation contains mixed spaces and tabs
dawr.py:161:1: E101 indentation contains mixed spaces and tabs
dawr.py:161:1: W191 indentation contains tabs
dawr.py:162:1: E101 indentation contains mixed spaces and tabs

Can you fix the test case?

@PraveenPenguin seems like travis job did not run for this PR which explains why we missed these errors

@PraveenPenguin
Copy link
Member

@akanksha216 seems like there is some white space damage with the code you submitted. If I clone read_dawr_perf_interface branch and try to run the test I get

~ avocado run --max-parallel-tasks=1 trace/dawr.py No tests found for given test references: trace/dawr.py Try 'avocado -V list trace/dawr.py' for details

Pycodestyle reports several errors

pycodestyle dawr.py dawr.py:56:1: E101 indentation contains mixed spaces and tabs dawr.py:56:1: W191 indentation contains tabs dawr.py:58:1: E101 indentation contains mixed spaces and tabs dawr.py:78:1: E101 indentation contains mixed spaces and tabs dawr.py:78:1: W191 indentation contains tabs dawr.py:79:1: E101 indentation contains mixed spaces and tabs dawr.py:84:1: E101 indentation contains mixed spaces and tabs dawr.py:84:1: W191 indentation contains tabs dawr.py:85:1: E101 indentation contains mixed spaces and tabs dawr.py:148:80: E501 line too long (82 > 79 characters) dawr.py:154:1: E101 indentation contains mixed spaces and tabs dawr.py:154:1: W191 indentation contains tabs dawr.py:155:1: E101 indentation contains mixed spaces and tabs dawr.py:161:1: E101 indentation contains mixed spaces and tabs dawr.py:161:1: W191 indentation contains tabs dawr.py:162:1: E101 indentation contains mixed spaces and tabs

Can you fix the test case?

@PraveenPenguin seems like travis job did not run for this PR which explains why we missed these errors

yes @sacsant as we have travis run quota got expired, @akanksha216 requesting can you please resend commit again

@akanksha216
read_dawr_perf_interface
4aafc74 
Add new test cases for reading single DAWR register and
multiple DAWR registers with perf interface

Signed-off-by: Akanksha J N <akanksha@linux.ibm.com>
@abdhaleegit abdhaleegit self-requested a review May 6, 2024 06:28
abdhaleegit
abdhaleegit approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@abdhaleegit abdhaleegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naresh-ibm Naresh-ibm self-assigned this May 7, 2024
@PraveenPenguin
Copy link
Member

@akanksha216 as we discussed , please close this PR and raise another just to run Travis

@Naresh-ibm
Copy link
Collaborator

@akanksha216 @PraveenPenguin are we perusing this PR? or as requested by Praveen, @akanksha216 are you going to send new PR and closing this?

@akanksha216 akanksha216 mentioned this pull request Aug 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PraveenPenguin PraveenPenguin PraveenPenguin left review comments

@abdhaleegit abdhaleegit abdhaleegit approved these changes

Assignees

@Naresh-ibm Naresh-ibm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akanksha216 @sacsant @PraveenPenguin @Naresh-ibm @abdhaleegit