Done automation for scheduler workflow. #2723

SamirMulani · 2023-10-17T08:34:39Z

In this automation below test cases are added,

Preparing the setup for sched_scoreboard github repo.
Run the workload command with starce command.
Run the workload command with perf stat command.
Run the workload command with trace command.

vishalc-ibm · 2023-11-12T16:14:22Z

cpu/log_generator.py

+        scoreboard_setup_log_file = self.logdir + "/sched_scoreboard_setup"
+        os.mkdir(scoreboard_setup_log_file)
+
+        log_file = "%s/starce_command_output_%s.log" % (


s/starce/sched_scoreboard/

vishalc-ibm · 2023-11-12T16:15:48Z

cpu/log_generator.py

+
+    def test_starce_cmd(self):
+        """
+        Run the starce command


s/starce/strace/

please replace throughout the file

vishalc-ibm · 2023-11-12T16:21:20Z

cpu/log_generator.py

+        cmd = 'echo >> "%s" 2>&1' % (log_file)
+        process.run(cmd, ignore_status=True, sudo=True, shell=True)
+
+        for i in range(self.repeat):


This method sets up sched-scoreboard repo and later runs the user supplied command through time utility. Please refactor into two seperate methods.

setup of sched-scoreboard repo can be done inside setUp() method

vishalc-ibm · 2023-11-29T11:59:07Z

cpu/log_generator.py

@@ -81,6 +68,20 @@ def test_sched_scoreboard_setup(self):
                (self.sched_scoreboard_dir)
            process.run(cmd, ignore_status=True, sudo=True, shell=True)

+    def test_sched_scoreboard_setup(self):
+        """_summary_


This comment can be removed

vishalc-ibm · 2023-11-29T12:01:39Z

cpu/log_generator.py

@@ -81,6 +68,20 @@ def test_sched_scoreboard_setup(self):
                (self.sched_scoreboard_dir)
            process.run(cmd, ignore_status=True, sudo=True, shell=True)

+    def test_sched_scoreboard_setup(self):


Please rename this method to test_run_with_time_repeat

vishalc-ibm · 2023-11-29T12:12:36Z

cpu/log_generator.py

+        Here in this test case we are cloning the sched_scoreboard
+        repo and prepareing the sched_scoreboard to run.
+        """
+        scoreboard_setup_log_file = self.logdir + "/sched_scoreboard_setup"


This part will change to...

time_log_file = self.logdir + "/time" os.mkdir(time_log_file) log_file = "%s/time_command_output_%s.log" % ( time_log_file, self.kernel_ver)

vishalc-ibm · 2023-11-29T12:21:31Z

cpu/log_generator.py

+        cmd = 'echo "Using command: %s >> %s" 2>&1' % (
+            self.user_command, log_file)
+        process.run(cmd, ignore_status=True, sudo=True, shell=True)
+
        cmd = 'lscpu >> "%s" 2>&1' % (log_file)


This test need not run lscpu
This should get captured by sysinfo utility
(preferably per-job)

Also, If we can collect other system level data such as lscpu, mpstat -P ALL 1 1, numactl -H, uptime etc. apart from all other static data that sysinfo utility already collects

Also as part of sysinfo utility's pre, create a backup /sys/kernel/debug/sched of this directory.

vishalc-ibm · 2023-11-29T12:30:17Z

cpu/log_generator.py

@@ -100,15 +101,15 @@ def test_sched_scoreboard_setup(self):
                self.user_command, log_file)
            process.run(cmd, ignore_status=True, sudo=True, shell=True)


process.run(cmd, ignore_status=True, sudo=True, shell=True) cmd = 'echo >> "%s" 2>&1' % (log_file) process.run(cmd, ignore_status=True, sudo=True, shell=True) # Execute the command and append the output to the log file for i in range(self.repeat): cmd = 'eval "$user_command" >> "%s" 2>&1' % (log_file) process.run(cmd, ignore_status=True, sudo=True, shell=True) cmd = 'echo >> "%s" 2>&1' % (log_file) process.run(cmd, ignore_status=True, sudo=True, shell=True) for i in range(self.repeat): # Execute the command and append the output to the log file cmd = '/usr/bin/time -v $(echo %s) >> "%s" 2>&1' % ( self.user_command, log_file) process.run(cmd, ignore_status=True, sudo=True, shell=True)

Please refactor this part to separate test_* methods as following:

test_run_command: This method would run user_command one time

test_run_command_with_profilers: This method would run user_command one time but with profilers enabled. (using sysinfo utility to run profilers per-test but for test_run_command_with_profilers only)

test_run_command_repeat: This method would run user_command repeat times

test_run_with_time_repeat: Will just be another test method to run the user_command through time command repeated repeat times

vishalc-ibm · 2023-11-29T13:09:17Z

cpu/log_generator.py

+                self.user_command, log_file)
+            process.run(cmd, ignore_status=True, sudo=True, shell=True)
+
+    def test_strace_cmd(self):


s/test_strace_cmd/test_run_with_strace_repeat/

vishalc-ibm · 2023-11-29T13:09:47Z

cpu/log_generator.py

+        for i in range(2):
+            process.run(cmd, ignore_status=True, sudo=True, shell=True)
+
+    def test_perf_stat_cmd(self):


s/test_perf_stat_cmd/test_run_with_perf_stat_repeat/

vishalc-ibm · 2023-11-29T13:11:29Z

cpu/log_generator.py

+            self.repeat, self.user_command, log_file)
+        process.run(cmd, ignore_status=True, sudo=True, shell=True)
+
+    def test_sched_scoreboard_cmd(self):


s/test_sched_scoreboard_cmd/test_run_with_sched_scoreboard/

vishalc-ibm · 2023-11-29T13:12:02Z

cpu/log_generator.py

+                                      log_file)
+        process.run(cmd, ignore_status=True, sudo=True, shell=True)
+
+    def test_trace_cmd(self):


s/test_trace_cmd/test_run_with_trace_cmd/

PraveenPenguin · 2024-02-12T02:59:28Z

@SamirMulani @vishalc-ibm any thing pending here , @SamirMulani even can you please squash both the commits in single commit

In this automation below test cases are added, 1. Preparing the setup for sched_scoreboard github repo. 2. Run the workload command with starce command. 3. Run the workload command with perf stat command. 4. Run the workload command with trace command. Signed-off-by: Samir Mulani <samir@linux.vnet.ibm.com> Done automation for scheduler workflow. Addressed review comments, 1. Fixed typo error. 2. Moved sched_scoreboard repo setup into setUp() method Signed-off-by: Samir Mulani <samir@linux.vnet.ibm.com>

SamirMulani force-pushed the scheduler_workflow branch from 2f6e663 to ce615dd Compare October 17, 2023 08:54

abdhaleegit requested review from abdhaleegit and PraveenPenguin October 25, 2023 05:05

vishalc-ibm reviewed Nov 12, 2023

View reviewed changes

vishalc-ibm reviewed Nov 29, 2023

View reviewed changes

SamirMulani force-pushed the scheduler_workflow branch from 04ba52e to 5526061 Compare June 24, 2024 09:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Done automation for scheduler workflow. #2723

Done automation for scheduler workflow. #2723

SamirMulani commented Oct 17, 2023

vishalc-ibm Nov 12, 2023

vishalc-ibm Nov 12, 2023

vishalc-ibm Nov 12, 2023

vishalc-ibm Nov 12, 2023 •

edited

Loading

vishalc-ibm Nov 12, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023

vishalc-ibm Nov 29, 2023

PraveenPenguin commented Feb 12, 2024

		@@ -100,15 +101,15 @@ def test_sched_scoreboard_setup(self):
		self.user_command, log_file)
		process.run(cmd, ignore_status=True, sudo=True, shell=True)

Done automation for scheduler workflow. #2723

Are you sure you want to change the base?

Done automation for scheduler workflow. #2723

Conversation

SamirMulani commented Oct 17, 2023

vishalc-ibm Nov 12, 2023

Choose a reason for hiding this comment

vishalc-ibm Nov 12, 2023

Choose a reason for hiding this comment

vishalc-ibm Nov 12, 2023

Choose a reason for hiding this comment

vishalc-ibm Nov 12, 2023 • edited Loading

Choose a reason for hiding this comment

vishalc-ibm Nov 12, 2023 • edited Loading

Choose a reason for hiding this comment

vishalc-ibm Nov 29, 2023

Choose a reason for hiding this comment

vishalc-ibm Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

vishalc-ibm Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

vishalc-ibm Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

vishalc-ibm Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

vishalc-ibm Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

vishalc-ibm Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

vishalc-ibm Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

vishalc-ibm Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

vishalc-ibm Nov 29, 2023

Choose a reason for hiding this comment

vishalc-ibm Nov 29, 2023

Choose a reason for hiding this comment

PraveenPenguin commented Feb 12, 2024

vishalc-ibm Nov 12, 2023 •

edited

Loading

vishalc-ibm Nov 12, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading

vishalc-ibm Nov 29, 2023 •

edited

Loading