-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bonding: Add support for mac base input interfaces #2697
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ Note: | |
----------------------------- | ||
Inputs Needed To Run Tests: | ||
------------------------------ | ||
bond_interfaces --> Interfaces in the Host machine requird for Bonding | ||
bond_interfaces --> Interfaces names or mac address space separated in the Host machine requird for Bonding | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you populate example string as well There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sure |
||
Note: example bond_interfaces = "ib0 ib1", Space between the interface names | ||
peerip --> peer ip address | ||
peer_interfaces --> This is needed only if a Bond interface is to be created in the Peer machine, space separated names if specifying multiple | ||
|
@@ -31,5 +31,3 @@ Requirements: | |
----------------------- | ||
1. install netifaces using pip | ||
command: pip install netifaces | ||
2. Generate sshkey for your test partner to run the test uninterrupted.(Have a passwordless ssh between the peers) | ||
3. Make sure IPs are set for interfaces to be used, via configuration file. ifup / ifdown should set the IPs back. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why remove this info are we doing this in the test? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. both the requirements are already automated into script.. so they are not needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change is this was bug earlier , if yes push this in another commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to safely exit teardown.. if interfaces are not available.. or wrong user input