Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(localstored): mark "engine"-option as optional #372

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix(localstored): mark "engine"-option as optional #372

merged 1 commit into from
Jan 30, 2023

Commits on Dec 30, 2022

  1. fix(localstored): mark "engine"-option as optional 

    The documentation and code mark the "engine"-prop as optional. However, the TypeScript type enforces it to be required, therefore any consumer who tries to omit this prop and use the default build-in engine gets a TypeScript error.

This change updates the argument-type of localstored, such that the "engine"-option becomes optional. Which allows a consumer to use the default build-in LocalStorage-based engine.
    @Addono
    Addono authored Dec 30, 2022
    Configuration menu
    Copy the full SHA
    fb05433 View commit details
    Browse the repository at this point in the history