Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Repeatable Annotation Name Collision #739

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

SentryMan
Copy link
Collaborator

When using JDK 23+ module imports, the List type from java.base and io.avaje.inject.aop have a name collision.

import module java.base;
import module io.avaje.inject;

public class Example {

  void main() {
    List.of(); // this fails to resolve the import
  }
}

@SentryMan SentryMan added the bug Something isn't working label Nov 20, 2024
@SentryMan SentryMan self-assigned this Nov 20, 2024
@SentryMan SentryMan enabled auto-merge (squash) November 20, 2024 15:07
Copy link
Contributor

@rbygrave rbygrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !!

@SentryMan SentryMan merged commit d8cc06d into avaje:master Nov 20, 2024
7 checks passed
@rbygrave rbygrave added this to the 10.7 milestone Nov 20, 2024
@SentryMan SentryMan deleted the module-import branch November 20, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants