Rename GetPeerList and PeerList messages #3182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
won-js
requested review from
danlaine,
darioush,
dboehm-avalabs,
abi87,
marun,
joshua-kim and
StephenButtolph
as code owners
joshua-kim
requested changes
Jul 10, 2024
config/config.go
Outdated
| PeerListNumValidatorIPs: v.GetUint32(NetworkPeerListNumValidatorIPsKey), | ||
| PeerListPullGossipFreq: v.GetDuration(NetworkPeerListPullGossipFreqKey), | ||
| PeerListBloomResetFreq: v.GetDuration(NetworkPeerListBloomResetFreqKey), | ||
| PeersGossipConfig: network.PeersGossipConfig{ |
There was a problem hiding this comment.
Applicable to the similar spots in this PR but we should name this PeerGossipConfig since PeersGossipConfig reads awkwardly.
There was a problem hiding this comment.
Thank you for reviewing.
I am not a native English speaker, so I'm not very familiar with it.
I have made the changes.
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Resolve #3128
Discussion and alternatives
I have not changed the "peerLists" in network/network.go.
Should I change it to peers?
How this works
How this was tested