Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename GetPeerList and PeerList messages #3133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Rename GetPeerList and PeerList messages #3133

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09e2d52
Rename GetPeerList and PeerList messages
MukulKolpe Jun 20, 2024
39fc4c0
Rename GetPeerList and PeerList messages
MukulKolpe Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/keys.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@ const (
NetworkHealthMaxPortionSendQueueFillKey = "network-health-max-portion-send-queue-full"
NetworkHealthMaxSendFailRateKey = "network-health-max-send-fail-rate"
NetworkHealthMaxOutstandingDurationKey = "network-health-max-outstanding-request-duration"
NetworkPeerListNumValidatorIPsKey = "network-peer-list-num-validator-ips"
NetworkPeerListPullGossipFreqKey = "network-peer-list-pull-gossip-frequency"
NetworkPeerListBloomResetFreqKey = "network-peer-list-bloom-reset-frequency"
NetworkPeerListNumValidatorIPsKey = "network-peers-num-validator-ips"
NetworkPeerListPullGossipFreqKey = "network-peers-pull-gossip-frequency"
NetworkPeerListBloomResetFreqKey = "network-peers-bloom-reset-frequency"
NetworkInitialReconnectDelayKey = "network-initial-reconnect-delay"
NetworkReadHandshakeTimeoutKey = "network-read-handshake-timeout"
NetworkPingTimeoutKey = "network-ping-timeout"
Expand Down
4 changes: 2 additions & 2 deletions message/ops.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,9 @@ func (op Op) String() string {
case HandshakeOp:
return "handshake"
case GetPeerListOp:
return "get_peerlist"
return "get_peers"
case PeerListOp:
Comment on lines 214 to 216
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are still a number of places in the code that reference PeerLists. These op types are an example, but I think a number of places in the network package need to be renamed as well as the p2p proto

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MukulKolpe were you still planning on working on this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm on it.

return "peerlist"
return "peers"
// State sync
case GetStateSummaryFrontierOp:
return "get_state_summary_frontier"
Expand Down