Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tutorials): add crosswalk passing scenario in tutorials page #514

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Ericpotato
Copy link
Contributor

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Ericpotato
Copy link
Contributor Author

@shmpwk It seems that I don't have the accessibility to assign a label or a reviewer. Can you help me ?

@Ericpotato Ericpotato marked this pull request as ready for review January 30, 2024 07:09
@shmpwk shmpwk added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jan 30, 2024
@shmpwk
Copy link
Contributor

shmpwk commented Jan 30, 2024

Great work! I will leave minor comment.

@shmpwk
Copy link
Contributor

shmpwk commented Jan 31, 2024

@Ericpotato
Please check spell check CI.

Ericpotato and others added 8 commits February 1, 2024 19:05
Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp>
Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp>
Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp>
Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp>
Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp>
Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp>
Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp>
@shmpwk
Copy link
Contributor

shmpwk commented Feb 5, 2024

As for signalized crosswalk, when the traffic light for the car is green and there is a pedestrian on the crosswalk which intersects with the planned route, the ego will drive without slowing down because of the crosswalk traffic light estimator.
Could you check the ego behavior again for the signalized crosswalk?

image

@shmpwk
Copy link
Contributor

shmpwk commented Feb 7, 2024

@Ericpotato
Could you modify the pull request title?

@Ericpotato Ericpotato changed the title docs(tutorials): add pull-over and pull-out scenario in tutorials page docs(tutorials): add crosswalk passing scenario in tutorials page Feb 7, 2024
@shmpwk shmpwk marked this pull request as draft March 29, 2024 10:45
Copy link

stale bot commented May 28, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants