-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(node-diagram): add routing api #450
Conversation
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
it may be not necessary to write and make confusing but
|
Thank you! I updated.
I'm being confused. How these messages are differentiated? |
change_route and change_route_points are called from routing
It's just FYI 🙏 This is a message for directly inputting a goal without api service, and is used in rviz's The flow is I think the topic name remains the same as in the old interface, so it might be better to rename to like |
I think that main tools already use api, but some tools still use the topic like |
ah, scenario_simulator_v2 also uses the topic, but will move to use api in the near future. |
@kosuke55 Thank you for the information. I updated the diagram. Would you review again? |
not the image of #450 (comment) but your updating is correct..!:pray: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Description
Add routing api in the node diagram
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.