docs: update creating autoware repositories page #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ismetatabay <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai>
ismetatabay
added
the
tag:deploy-docs
Signed-off-by: ismetatabay <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai>
4 tasks
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
...s/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories.md
Outdated
Show resolved
Hide resolved
|
Overall, I feel the contents related to the "Create Autoware Meta-repository Guide" are very good and easy to follow, I have made some suggestions to improve grammar and readability with some help from chatGPT @ismetatabay |
Signed-off-by: ismetatabay <ismet@leodrive.ai>
|
@danielsanchezaran, Thank you very much for your review comments. I completely agree with these changes, and I have implemented all of your suggestions. Consequently, I believe the code's readability and understandability have been enhanced 👍 |
10 tasks
|
@danielsanchezaran, @mitsudome-r Hi, is it okay to merge? |
|
LGTM |
mitsudome-r
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add more information about creating autoware meta-repository and other individual repositories. (autoware_launch, autoware_individual_params, sample_vehicle_launch and sample_sensor_kit_launch)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.