Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADC Example tested on Xult/EXT-1 PIN#4 (PA19/AFEC0_AD8) #66

Merged
merged 2 commits into from
Nov 28, 2023
Merged

ADC Example tested on Xult/EXT-1 PIN#4 (PA19/AFEC0_AD8) #66

merged 2 commits into from
Nov 28, 2023

Conversation

blietaer
Copy link
Contributor

Well, I just tested it on the Xult/EXT-1 PIN#4 (PA19/AFEC0_AD8), working fine: shall I commit the change ?

Copy link
Member

@tmplt tmplt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I cannot test it. Add an entry to the changelog and I'll approve.

@blietaer
Copy link
Contributor Author

CHANGELOG.md updated on my forked branch.

Copy link
Member

@tmplt tmplt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have new linting rules.

@michalfita
Copy link
Collaborator

@tmplt you meant failed CI? We build with MRV and latest to spot problems preventing users of newer compilers from using our crates. Most problems are addressed on branches waiting to be sort out and final release.

@michalfita michalfita merged commit ec0a398 into atsams-rs:development Nov 28, 2023
44 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants