This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 147
Implement naming conventions in Python grammar #313
Open
chbk
wants to merge
1
commit into
atom:master
Choose a base branch
from
chbk:scopes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chbk
force-pushed
the
scopes
branch
2 times, most recently
from
March 9, 2020 16:34
b27d680
to
779acc7
Compare
This was referenced Mar 17, 2020
chbk
force-pushed
the
scopes
branch
2 times, most recently
from
August 24, 2020 16:29
22915eb
to
0ff79d0
Compare
chbk
force-pushed
the
scopes
branch
2 times, most recently
from
January 12, 2021 04:40
9c03c21
to
7626d1f
Compare
aminya
suggested changes
Jan 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, please separate different fixes to different commits. If this PR is a complete rewrite, then it is fine.
Yeah it's a rewrite, difficult to partition into separate commits. |
This was referenced Jan 12, 2021
chbk
force-pushed
the
scopes
branch
2 times, most recently
from
January 18, 2021 10:48
62c7d54
to
63f9b7c
Compare
Screenshots of different example code in different themes (light/dark/popular/built-in) to show the changes would help a lot for reviewing |
Besides the screenshots above, what would you suggest? |
Can we merge this? |
I think this is good to merge |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This is a rewrite of the Tree-sitter grammar to implement naming conventions for syntax scopes.
Benefits
Possible Drawbacks
Some new scopes to be added to themes. The changes aim to facilitate theme development, filling the template is enough to ensure coherent highlighting across languages, instead of painfully creating styling rules for every language separately.
Applicable Issues
Related Pull Requests