Update logging #60
Merged
Update logging #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprilgill
reviewed
Sep 12, 2023
src/client/gitlab.ts
Outdated
| const { data } = await callGitlab(`/api/v4/groups?${queryParams}`, groupAccessToken); | ||
|
|
||
| return data; | ||
| }; | ||
|
|
||
| export const registerGroupWebhook = async (payload: RegisterWebhookPayload): Promise<number> => { | ||
| const { groupId, token: groupToken, url, signature } = payload; | ||
| console.log(`Calling gitlab to register webhook`); |
There was a problem hiding this comment.
Maybe instead of logging at each method, callGitlab can take the name of the calling function and log it for all requests?
aprilgill
reviewed
Sep 12, 2023
src/client/gitlab.ts
Outdated
| @@ -162,13 +171,22 @@ export const getGroupWebhook = async ( | |||
| }; | |||
|
|
|||
| export const getGroupAccessTokens = async (groupToken: string, groupId: number): Promise<GroupAccessToken[]> => { | |||
| const { data: groupAccessTokenList } = await callGitlab(`/api/v4/groups/${groupId}/access_tokens`, groupToken); | |||
| console.log(`Calling gitlab to get group access tokens`); | |||
| return { | ||
| componentsToCreate: [], | ||
| componentsToUpdate: [], | ||
| componentsToUnlink: [], | ||
| }; | ||
| } | ||
| console.log( | ||
| `Found ${added.length} added diffs, ${removed.length} removed diffs, and ${added.length} removed diffs in push event. Now processing what files might have been moved or renamed.`, |
There was a problem hiding this comment.
not fully sure of the specifics of this file, but it seems like it would log "__ added diffs, __ removed diffs, and __ removed diffs" --> should the last "removed diffs" be something different or is that intended?
There was a problem hiding this comment.
oops yes sorry i was copy-pasting too fast LOL
shrestabangaru
approved these changes
Sep 13, 2023
aprilgill
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing some logging and adding logging for client calls
Checklist
Please ensure that each of these items has been addressed: