Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InitFlow and move session states to context #266

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

mirromutth
Copy link
Contributor

Motivation:

Session states are now dispersed across MySqlSimpleConnection and ConnectionContext, make these states to be managed in a single object.

Modification:

  • Add InitFlow for initialize handshake/login and session states
  • Add setSessionVariable and setSessionVariables to QueryFlow
  • Consolidate session variable statements into StringUtils
  • Move session states to ConnectionConext, e.g. PrepareCache, lockWaitTimeout, etc.

Result:

Refactored initialization and management of session states

@mirromutth mirromutth added the enhancement New feature or request label Mar 28, 2024
@mirromutth mirromutth added this to the 1.1.3 milestone Mar 28, 2024
@mirromutth mirromutth requested a review from jchrys March 28, 2024 02:06
@mirromutth mirromutth marked this pull request as ready for review March 28, 2024 02:45
@jchrys
Copy link
Collaborator

jchrys commented Mar 28, 2024

I just had a medical check-up; I'll review PRs tomorrow.

Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchrys
Copy link
Collaborator

jchrys commented Mar 29, 2024

Great change 👍

@mirromutth mirromutth merged commit e97dc7d into trunk Apr 1, 2024
15 checks passed
@mirromutth mirromutth deleted the feature/flows/init branch April 1, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants