Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADR-0006] Use PNPM package manager #1060

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Conversation

KhudaDad414
Copy link
Member

Description

  • I propose we use pnpm instead of npm in studio

Copy link

changeset-bot bot commented Apr 3, 2024

⚠️ No Changeset found

Latest commit: d1f9013

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit d1f9013
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/662b884330a00f00084d95b8
😎 Deploy Preview https://deploy-preview-1060--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit d1f9013
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/662b8843f820d300087c1aa6
😎 Deploy Preview https://deploy-preview-1060--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for studio-next ready!

Name Link
🔨 Latest commit d1f9013
🔍 Latest deploy log https://app.netlify.com/sites/studio-next/deploys/662b88434a8fba00088a1a0b
😎 Deploy Preview https://deploy-preview-1060--studio-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add the pnpm-lock.yaml and pnpm-workspace_yaml as well.

@Shurtu-gal
Copy link
Collaborator

We can add the pnpm-lock.yaml and pnpm-workspace_yaml as well.

The README should also be changed.

@Shurtu-gal Shurtu-gal added the kind/adr create a new architectural decision record. label Apr 3, 2024
@KhudaDad414
Copy link
Member Author

@Shurtu-gal after we have an approval from other code-owners, I can move forward with an another PR implementing the change and making sure it works properly with Turborepo.

Copy link
Collaborator

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I myself have been using pnpm for quite some time now, and agree with this change 🥳.

Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@KhudaDad414
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 5372044 into master Apr 26, 2024
24 checks passed
@asyncapi-bot asyncapi-bot deleted the KhudaDad414-patch-1 branch April 26, 2024 12:05
@KhudaDad414 KhudaDad414 mentioned this pull request Apr 27, 2024
3 tasks
KhudaDad414 added a commit to KhudaDad414/studio that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/adr create a new architectural decision record. ready-to-merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants