fix(website): fix broken open graph images #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for modelina ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Pull Request Test Coverage Report for Build 9738289895Details
💛 - Coveralls |
| }: HeadProps) { | ||
| const url = process.env.DEPLOY_PRIME_URL || process.env.DEPLOY_URL; | ||
| const url = 'https://modelina.org'; |
There was a problem hiding this comment.
We can set an environment variable for this in the netlify instead of directly mentioning it here and use it as it was used earlier.
cc: @jonaslagoni
There was a problem hiding this comment.
@devilkiller-ag Make sure to start with NEXT_PUBLIC_ (process.env.NEXT_PUBLIC_DEPLOY_URL), if you want to include the environment variable on the browser
There was a problem hiding this comment.
I have added the environment variable on the Netlify with the name 'NEXT_PUBLIC_DEPLOY_URL'
Pull Request Test Coverage Report for Build 9740279802Details
💛 - Coveralls |
devilkiller-ag
approved these changes
Jul 6, 2024
|
/rtm |
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Images in HeadComponents is not the actual folder where the images have been put in
Related Issue
Fixes #1165