test: add runtime testing for Go models #1484
Conversation
Devansh-Bhatt
requested review from
magicmatatjahu,
jonaslagoni,
kennethaasan and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for modelina ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Looks great @Devansh-Bhatt!
Just got those two comments, and then please use test: as the PR title 🙂
| Members: nil, | ||
| ArrayType: nil, | ||
| NestedObject: nil, | ||
| AdditionalProperties: nil, |
There was a problem hiding this comment.
@Devansh-Bhatt if you look at one of the other runtime test, do you mind using the same values as in there? 🙂
| "testing" | ||
| ) | ||
|
|
||
| func TestShouldbeAbleToSerializeModel(t *testing.T) { |
There was a problem hiding this comment.
We still need to compare the actual serialized value with something we expect, you can grab the one in the other runtime test 🙂
There was a problem hiding this comment.
@jonaslagoni .. I tried to find the expected json in other runtime-tests but couldn't find one. The closest thing i found was under typescript-test where the serialized json was expected : {\"street_name\": \"test\",\"house_number\": 1,\"array_type\": [1,\"test\"],\"nestedObject\": {\"test\": \"test\"}} and this was done for every field of the Address Struct.
Do you expect me to do the same as done in typescript ?
[As in java and other languages i did not find any expected json's] 🙂
Pull Request Test Coverage Report for Build 5964862281
💛 - Coveralls |
Devansh-Bhatt
changed the title
Devansh-Bhatt
changed the title
jonaslagoni
changed the title
|
SonarCloud Quality Gate failed.
|
|
@jonaslagoni Is there any issue with the commit / changes that i made. I quite don't seem to understand what's the issue here 😕 |
|
@all-contributors please add @Devansh-Bhatt for test, infra |
|
I've put up a pull request to add @Devansh-Bhatt! 🎉 |
|
🎉 This PR is included in version 1.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-next.25 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
test/runtime/runtime-gotest/runtime/runtime-gopackage.jsontest/runtime/runtime-go/targetwhich contained the auto generated models as a result of running the generation scripttest/runtime/runtime-go/Test_Go/Test_Address.gopackage.json.github/workflows/runtime-go-testing.ymlRelated issue(s)
Resolves #1333