refactor: relocated twitter extension #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambhavgupta0705
requested review from
fmvilas,
derberg and
asyncapi-bot-eve
as code owners
derberg
requested changes
Oct 25, 2023
There was a problem hiding this comment.
I'm pretty sure we discussed that metadata should not be added to a file here. It should be done through automation, title taken from filename and weight calculated from alphabetic order of extensions
please also update https://github.com/asyncapi/extensions-catalog/pull/131/files with info:
- where extension must be placed
- rules to follow with filename
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
derberg
approved these changes
Nov 8, 2023
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue:
#78
twitter.mdin the extensions folder.