-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: solved asyncapi help #843
Conversation
merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayushnau good progress, I see you figured out how the hooks work, I have a couple of things to add.
- Instead of logging
help command not found.
it would be useful to point the user, on how to get help. Since we have the--help
flag we can talk about how to use that flag to access help. - We are currently using an oclif plugin called @oclif/plugin-not-found which helps users by giving suggestions on the commands, I think with your current change this library is not working correctly. (have a look at this, open a new branch from the master to check how it works)
@Souvikns I have already seen through the pluggin command not found and understood, how it works upto certain extent. now I am thinking to implement it as a hook (it is also actually a hook ). with same code as it had. just need to know specification how should i go about this. and also if command not found is triggered how should I point to --flag. means let suppose user type asyncapi help should i print it as try asynapi --help |
|
@ayushnau there are some issues with lint can you check it, also sonar cloud is failing have a look at that as well. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@Souvikns please merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @ayushnau, I checked the commands locally, and it works as expected 👍🏼
/rtm |
🎉 This PR is included in version 0.58.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixed the bug of asyncpi help
Description
Related issue(s)
#559