-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add log to show the version status of cli #1393
Conversation
@AayushSaini101 I suppose it the message should be infrequent so as not to bother users. |
@Shurtu-gal Thanks, used the probaility method to show the message when the probaility is less than 0.5. Sample Testing of message: |
Agree, especially if we don't have (yet) an auto-update feature. |
@AayushSaini101 why not just use https://github.com/oclif/plugin-warn-if-update-available, instead of having the random check for simplicity the plugin provides a periodic check that is more common. We can check every 24h for instance. Some other useful plugins we can add: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Amzani @KhudaDad414 Added plugin and configuration to run in 24 hour. |
Co-authored-by: Khuda Dad Nomani <32505158+KhudaDad414@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
/rtm |
@AayushSaini101 the tests seem to be cancelled. can you push an empty commit to re-run the tests? |
Quality Gate passedIssues Measures |
Rerun @KhudaDad414 |
/rtm |
🎉 This PR is included in version 1.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Resolves: #1371