Prevent np.str_ column names in SourceCatalog table #1956
Merged
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larrybradley
force-pushed
the
fix-cat-table
branch
from
b18116a
to
a6d3603
Compare
larrybradley
force-pushed
the
fix-cat-table
branch
from
a6d3603
to
fa2c9a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the table output from the
SourceCatalogto_tablemethod could have column names with anp.str_representation instead ofstrrepresentation when using NumPy 2.0+.Many thanks to @jensmelinder for reporting this in #1952.
Fixes #1952.