Feature/housekeeping dataaccess #999
Open
+139
−1,331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinnokdisengir
force-pushed
the
feature/housekeeping-dataaccess
branch
2 times, most recently
from
563f6dd
to
d512f14
Compare
shinnokdisengir
requested review from
Annopaolo,
eddbbt,
davidebriani and
rbino
Annopaolo
requested changes
Oct 7, 2024
| @@ -72,7 +72,7 @@ defmodule Astarte.Housekeeping.Mixfile do | |||
| defp astarte_required_modules(_) do | |||
| [ | |||
| {:astarte_core, github: "astarte-platform/astarte_core"}, | |||
| {:astarte_data_access, github: "astarte-platform/astarte_data_access"}, | |||
| {:astarte_data_access, path: "/home/ghio/Documents/astarte_data_access"}, | |||
docker-compose.dev.yml
Outdated
There was a problem hiding this comment.
This change is not related, please remove from this PR
shinnokdisengir
force-pushed
the
feature/housekeeping-dataaccess
branch
from
d512f14
to
408a9ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #999 +/- ##
==========================================
+ Coverage 69.40% 71.26% +1.85%
==========================================
Files 263 249 -14
Lines 7119 6312 -807
==========================================
- Hits 4941 4498 -443
+ Misses 2178 1814 -364 ☔ View full report in Codecov by Sentry. |
shinnokdisengir
force-pushed
the
feature/housekeeping-dataaccess
branch
from
408a9ab
to
9c8cf39
Compare
eddbbt
reviewed
Oct 9, 2024
| @@ -84,7 +85,7 @@ defmodule Astarte.Housekeeping.ReleaseTasks do | |||
| end | |||
|
|
|||
| defp wait_connection_and_check_astarte_keyspace(retries \\ 60) do | |||
| case Queries.is_astarte_keyspace_existing() do | |||
| case Keyspace.keyspace_existing?("astarte") do | |||
There was a problem hiding this comment.
could be shortened as
Suggested change
| case Keyspace.keyspace_existing?("astarte") do | |
| with {:error, :database_connection_error} <- Keyspace.keyspace_existing?("astarte") do | |
| if retries > 0 do | |
| :timer.sleep(1000) | |
| wait_connection_and_check_astarte_keyspace(retries - 1) | |
| else | |
| {:error, :database_connection_error} | |
| end | |
| end |
cause when 'with' can not match, it returns the value (so {:ok, _} or {:error, _})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After porting all
realmoperations intoastarte_dataaccess,housekeepingneeds to be refactored using the newest apiNOTE: commit titles will be fixed after other changes