[WIP] AppEngine: Implement property-based tests for cast_value functions
#980
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #980 +/- ##
===============================================
- Coverage 69.62% 64.05% -5.57%
===============================================
Files 264 208 -56
Lines 7097 5659 -1438
===============================================
- Hits 4941 3625 -1316
+ Misses 2156 2034 -122 ☔ View full report in Codecov by Sentry. |
apps/astarte_appengine_api/test/astarte_appengine_api/device/interface_value_test.exs
Outdated
Show resolved
Hide resolved
apps/astarte_appengine_api/test/support/generators/interface-value.ex
Outdated
Show resolved
Hide resolved
apps/astarte_appengine_api/test/support/generators/interface-value.ex
Outdated
Show resolved
Hide resolved
apps/astarte_appengine_api/test/support/generators/interface-value.ex
Outdated
Show resolved
Hide resolved
Changed - using exandra -- waiting for database project - implemented jwt + public/private key - wip group tests - squashed all failure - polishing - removed one_of_constant -> member_of - splitted tests - WIP device generator - completed device generator...but using opaque data (TODO change it) - basic datetime generator - WIP device generator - using Keyword.validate! - WIP insert into db, IPNET error - completed device WIP id doesn't match - completed base tests device - polishing - renamed realm -> keyspace - completed group generator + setup + case - wip group test (group_name "!" doesn't work) - added encoded_id field to device test - unlinked Conn <-> Database cases - fixed realm name - fixed valid group name test - added already exists - polished - removed common.ex Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
Signed-off-by: Ismet Softic <ismet.softic@secomind.com>
Signed-off-by: Ismet Softic <ismet.softic@secomind.com>
Implement property-based tests for `cast_value` functions. Signed-off-by: Ismet Softic <ismet.softic@secomind.com>
Hibe7
force-pushed
the
implementPropertyBasedTests
branch
from
6168b87
to
d50b08b
Compare
Hibe7
changed the title
cast_value functions
| end | ||
|
|
||
| def invalid_binaryblob_array() do | ||
| list_of(invalid_binaryblob(), min_length: 1, max_length: 10) |
There was a problem hiding this comment.
invalid_binaryblob() |> list_of would be better? - (generators of invalid entites must be removed, see below)
| end | ||
|
|
||
| def invalid_datetime() do | ||
| StreamData.one_of([ |
There was a problem hiding this comment.
use use ExUnitProperties like file above
| date_time!(min, max) | ||
| end | ||
|
|
||
| def invalid_datetime() do |
There was a problem hiding this comment.
generators must produce valid entities. If you want to create a mistake, use a pattern similar to apps/astarte_appengine_api/test/astarte_appengine_api/v2_group_test.exs
There was a problem hiding this comment.
(If you need to reuse an invalid generator in more than one test, you could implement at the beginning of the test file)
| alias Astarte.Test.Generators.DateTime, as: DateTimeGenerator | ||
| alias Astarte.Test.Generators.Number, as: NumberGenerator | ||
| alias Astarte.Test.Generators.String, as: StringGenerator | ||
|
|
There was a problem hiding this comment.
@moduletag :v2
@moduletag :interface # or interface_value? It's the context
There was a problem hiding this comment.
the v2 tag is useful when we want to test only new version - property based - (ex. mix test --only v2)
| end | ||
|
|
||
| property "Valid binary blob values are correctly casted" do | ||
| check all blob <- StreamData.binary() do |
There was a problem hiding this comment.
remove unnecessary StreamData. - we are using use ExUnitProperties
| end | ||
|
|
||
| def longinteger_array() do | ||
| StreamData.one_of([ |
There was a problem hiding this comment.
My bad, I've forgotten to remove all StreamData. from this file. Please fix both of code
There was a problem hiding this comment.
Anyway, I don't like this approach: using two different function for integer and strings would be better. Then, you could create a mixed one (but it's odd, I prefer to maintain them seperately).
Also, look this code:
parsed_integers =
Enum.map(long_integer_array, fn
value when is_integer(value) -> value
value when is_binary(value) -> String.to_integer(value)
end)
PS: could you put these functions into a array.ex file?
| date_time!(min, max) | ||
| end | ||
|
|
||
| def invalid_datetime() do |
There was a problem hiding this comment.
(If you need to reuse an invalid generator in more than one test, you could implement at the beginning of the test file)
Implement property-based tests for
cast_valuefunctions.What this PR does / why we need it:
cast_valuefunctions.Special notes for your reviewer: