astarte_dev_tool: setup and features
#978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinnokdisengir
force-pushed
the
feature/astarte-dev-tool
branch
from
8c0c1ea
to
b802f25
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
==========================================
+ Coverage 67.99% 69.49% +1.50%
==========================================
Files 281 267 -14
Lines 7420 6613 -807
==========================================
- Hits 5045 4596 -449
+ Misses 2375 2017 -358 ☔ View full report in Codecov by Sentry. |
shinnokdisengir
force-pushed
the
feature/astarte-dev-tool
branch
from
b802f25
to
ff08b56
Compare
shinnokdisengir
force-pushed
the
feature/astarte-dev-tool
branch
2 times, most recently
from
006ecc8
to
7230a50
Compare
shinnokdisengir
changed the title
astarte_dev_tool: setup and featuresastarte_dev_tool: setup and features
shinnokdisengir
force-pushed
the
feature/astarte-dev-tool
branch
2 times, most recently
from
4330f4c
to
c2ee6f9
Compare
eddbbt
reviewed
Jul 18, 2024
eddbbt
reviewed
Jul 18, 2024
davidebriani
requested changes
Jul 18, 2024
Annopaolo
requested changes
Jul 18, 2024
There was a problem hiding this comment.
I suggest using a different commit structure:
- First, a "new" commit, containing the command used to generate the folder, and the generated files
- If needed, a "cleanup" commit, very briefly stating what's been removed and why
- A commit to add the different functionalities, explaining with some more detail what's the goal of these
shinnokdisengir
force-pushed
the
feature/astarte-dev-tool
branch
2 times, most recently
from
cbec7f0
to
b3890e4
Compare
davidebriani
requested changes
Jul 18, 2024
eddbbt
suggested changes
Jul 18, 2024
davidebriani
requested changes
Jul 18, 2024
shinnokdisengir
force-pushed
the
feature/astarte-dev-tool
branch
4 times, most recently
from
eea6086
to
a9aad2e
Compare
The branch is based on astarte-platform#956, which is necessary to start `docker compose` in development mode Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
shinnokdisengir
force-pushed
the
feature/astarte-dev-tool
branch
from
cac6ca8
to
19e8140
Compare
shinnokdisengir
force-pushed
the
feature/astarte-dev-tool
branch
from
19e8140
to
f4c1f04
Compare
eddbbt
reviewed
Jul 19, 2024
davidebriani
requested changes
Jul 19, 2024
tools/astarte_dev_tool/lib/mix/tasks/astarte_dev_tool/system/down.ex
Outdated
Show resolved
Hide resolved
eddbbt
reviewed
Jul 19, 2024
Annopaolo
requested changes
Jul 19, 2024
shinnokdisengir
force-pushed
the
feature/astarte-dev-tool
branch
from
f4c1f04
to
4a47d1f
Compare
davidebriani
approved these changes
Jul 19, 2024
rbino
reviewed
Jul 19, 2024
Addition of `astarte_dev_tool` functionalities: the functionalities are stateless and based on the `mix task` mechanism - [X] `mix astarte_dev_tool.system.up`: start `docker compose` in dev mode - [x] `mix astarte_dev_tool.system.down`: stop `docker compose` in dev mode - [X] `mix astarte_dev_tool.system.watch`: watch mode to enable hot-code-reloading Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
shinnokdisengir
force-pushed
the
feature/astarte-dev-tool
branch
from
4a47d1f
to
cbb2db2
Compare
Annopaolo
approved these changes
Jul 19, 2024
shinnokdisengir
added a commit
to shinnokdisengir/astarte
that referenced
this pull request
Oct 10, 2024
In order to _local_ develop astarte via `dev mode`, using [`astarte-dev-tool up`](astarte-platform#978) or using `docker compose watch`, cassandra/scylla needs to expose the port used to connection. Otherwise, the connection are only available via cluster. With this PR scylla/cassandra is exposed on `localhost:9042` Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
astarte_dev_toolfirst commitThe branch is based on #956, which is necessary to start
docker composein development modeAddition of
astarte_dev_toolfunctionalities: the functionalities are statelessand based on the
mix taskmechanismmix astarte_dev_tool.system.up: startdocker composein dev modemix astarte_dev_tool.system.down: stopdocker composein dev modemix astarte_dev_tool.system.watch: watch mode to enable hot-code-reloading