chore(infra): move tests folder to top level #89
+36
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoonIter
force-pushed
the
soon/chore/infra
branch
2 times, most recently
from
2103237
to
4a1d7f2
Compare
SoonIter
force-pushed
the
soon/chore/infra
branch
from
3ab8183
to
1f11b4f
Compare
|
any merit to move test to top level? |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good to me!
Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.
Generated with ❤️ by ellipsis.dev
:-) There are no obvious benefits but I think we will move the tests directory to the top layer sooner or later, because we use tsx to run ts code instead of compiling it. By the way, I'm testing the failing reason for window CI in this pr , it seems that Macos is also unstable ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR moves the
testsfolder to the top level of the project structure and updates various files to reflect this change, including workflow files, test setup scripts, and test files.Key points:
testsfolder to top level..github/workflows/ci.ymland.github/workflows/publish.ymlto use.nvmrcfor Node.js version.scripts/test/testSetup.tsto importactivatefrom newutilslocation.src/extension.tsto usepath.joinforconfigUri.src/testtotests.src/test/utils.tstotests/utils.ts.Generated with ❤️ by ellipsis.dev