Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Setup GitHub actions #3374

Open
wants to merge 12 commits into
base: v2-bridge
Choose a base branch
from
Open

Conversation

christopheGaon
Copy link
Contributor

@christopheGaon christopheGaon commented Jan 26, 2024

Description

remplacer circle-ci par github-action pour le build and publish sur npm

Playground - Pour tester

Liste des job disponible

 act -l 

Stage  Job ID       Job name     Workflow name                             Workflow file    Events      
0      ci           ci           Library DS CI - Synpase                   ci.yml           pull_request
0      validate     validate     Library DS Package and Publish - Synpase  npm-publish.yml  release     
1      publish-npm  publish-npm  Library DS Package and Publish - Synpase  npm-publish.yml  release 

pour lancer le job ci
act -v -j ci 

Type de changement

  • Nouvelle fonctionnalité
  • Refactoring

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

bidule added 3 commits January 26, 2024 12:43
- build: install dependacy
- npm-publish: publish on npm using token

wip
- test with event in github
- test with the token the publish job
@christopheGaon christopheGaon requested a review from a team January 26, 2024 11:57
@christopheGaon christopheGaon self-assigned this Jan 26, 2024
@christopheGaon christopheGaon added dependencies Concerne les dépendances configuration Concerne la configuration enhancement Nouvelle fonctionnalité labels Jan 26, 2024
@christopheGaon christopheGaon linked an issue Jan 26, 2024 that may be closed by this pull request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faut laisser ce fichier pour que CircleCI ignore cette branche et celles qui sont crées à partir de celle-ci

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je l ai remis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mais j ai desacitver le circle ci , donc je suis pas sur que cela soit necessaire ?? non ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faut le mettre vu qu'on a réactivé CircleCI pour la v2

.github/workflows/npm-publish.yml Outdated Show resolved Hide resolved
.github/workflows/npm-publish.yml Outdated Show resolved Hide resolved
- uses: actions/setup-node@v3
with:
node-version: 20.11.0
# cache: 'pnpm'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# cache: 'pnpm'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en local c est l enfer pour tester mais on peut le mettre en prod

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faudrait le variabiliser du coup non ?

Comment on lines 1 to 4
# This workflow will run tests using node and then publish a package to GitHub Packages when a release is created
# For more information see: https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages

name: Node.js Package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# This workflow will run tests using node and then publish a package to GitHub Packages when a release is created
# For more information see: https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages
name: Node.js Package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c etait pour avoir les sources qui m ont aidé à le mettre en place

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faut mettre à jour le commentaire alors (ou ne laisser que le lien)

@christopheGaon christopheGaon linked an issue Jan 26, 2024 that may be closed by this pull request
@christopheGaon christopheGaon requested review from deraw and a team January 30, 2024 16:04
@deraw deraw removed dependencies Concerne les dépendances enhancement Nouvelle fonctionnalité labels Feb 6, 2024
@deraw deraw changed the title clean circle-ci and pass to github action to build lib and publish in npm 🔧 Setup GitHub actions Feb 6, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/npm-publish.yml Outdated Show resolved Hide resolved
.github/workflows/npm-publish.yml Outdated Show resolved Hide resolved
actions/ci.yml Outdated Show resolved Hide resolved
actions/ci.yml Outdated Show resolved Hide resolved
review @dylan

Co-authored-by: Dylan Broussard <contact@deraw.dev>
@oc8
Copy link

oc8 commented Mar 20, 2024

Certaines fonctionnalités sont bloquées ? @christopheGaon
Capture d’écran 2024-03-20 à 11 11 37

@oc8
Copy link

oc8 commented Mar 22, 2024

Certaines fonctionnalités sont bloquées ? @christopheGaon Capture d’écran 2024-03-20 à 11 11 37

C'est bon merci David.
La CI fonctionne, mais à quoi sert circle ci ? Peut-être le supprimer puisqu'on ne l'utilise pas ?

@VachetVirginie
Copy link
Contributor

Est il possible de rajouter la cmd vue-tsc pour tester aussi le typescript?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Concerne la configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants