New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default FileMixin#as_json options argument to nil #141

Open

AlexWheeler wants to merge 1 commit into assembler:master from AlexWheeler:default-as-json-argument-to-nil

AlexWheeler commented Oct 19, 2016 •

edited

Loading

Fixes #142

active_support expects as_json to optionally accept an options hash argument
line 93 in https://github.com/rails/rails/blob/master/activesupport/lib/active_support/json/encoding.rb calls as_json without an argument so this breaks when trying to jsonify an attachinary file instance
removes trailing whitespace


          default FileMixin#as_json options argument to nil

2c7d0b6

* active_support expects a method that optionally accepts options

lucasvel mentioned this pull request

Update file_mixin.rb songfinch/attachinary#3

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet