Array.prototype.lengthをアクセッサプロパティで再現するのサンプルコードをリファクタリングした #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this.items.lengthの部分はthisにgetterのlengthが生えているため、可読性を考慮してthis.lengthに変更した
✅ Deploy Preview for js-primer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
azu
reviewed
Feb 27, 2023
| const currentItemLength = this.items.length; | ||
| const currentItemLength = this.length; |
There was a problem hiding this comment.
個人的には下で this.items.slice(0, newLength); と this.items を参照してるので、ここでは this.items の length を見るのが正しいかなーとは思いました
(get length()と get items()の実装が異なる可能性があるのと、一貫性)
また、currentItemLength なので this.length だとItemのlengthだとちょっとわかりにくいというのもあります。
あと、setterの中で同じ名前のgetterを参照するのはなんか無限ループ感があってちょっと怖いというが感覚的に避けたい理由ですかね。
There was a problem hiding this comment.
多分一番良いのは、getter/setter内からはgetter/setterを触らないようにするという感じにして、ここでもthis._itemsを常に使うとかなのかなーとはちょっと思いました。
getter/setterそのものが可読性的には微妙なので(見た目で区別ができない)、改善するとしたら一貫性なのかなーとは思いました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
クラスのArray-likeオブジェクトの項(https://jsprimer.net/basic/class/#array-like-length)で
this.items.lengthの部分はthis(ArrayLikeクラスのインスタンス)にgetterのlengthが生えているため、可読性を考慮してthis.lengthに変更しました。ご検討ください。