Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored using __init__ and class import for #83 #85

Merged
merged 4 commits into from
Jan 15, 2022
Merged

refactored using __init__ and class import for #83 #85

merged 4 commits into from
Jan 15, 2022

Conversation

kgashok
Copy link
Collaborator

@kgashok kgashok commented Jan 14, 2022 •
edited
Loading

Partial fix for #83

  • TIL AttributeError: Module "foo" has no attribute "bar" has a easy resolution
  • Thanks to this (a hack?), os/sys calls have been refactored out.

Initial files for #86

Check everything which applies

  • I have added the issue number for which this pull request is created.
  • Ran pytest locally to completion.

arshadkazmi42
arshadkazmi42 requested changes Jan 15, 2022
View reviewed changes
Copy link
Owner

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, using Makefile seems like a good idea.

I have added a small comment, let me know your thoughts

tests/test_basics.py Outdated Show resolved Hide resolved
arshadkazmi42
arshadkazmi42 approved these changes Jan 15, 2022
View reviewed changes
Copy link
Owner

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@arshadkazmi42 arshadkazmi42 merged commit 02e5601 into arshadkazmi42:master Jan 15, 2022
BadKarma187
BadKarma187 reviewed Apr 8, 2023
View reviewed changes
Copy link

@BadKarma187 BadKarma187 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BadKarma187 BadKarma187 BadKarma187 left review comments

@arshadkazmi42 arshadkazmi42 arshadkazmi42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgashok @arshadkazmi42 @BadKarma187