Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve php dependencies support #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve php dependencies support #38

wants to merge 1 commit into from

Conversation

fernandoomarcelino
Copy link

  • Add PHP 8.2 support

diniz-victor
diniz-victor previously approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@diniz-victor diniz-victor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me.

@xico42
Copy link
Contributor

xico42 commented Mar 31, 2023

Could you add php 8.2 support to the github actions pipeline?

@diniz-victor
Copy link
Contributor

Could you add php 8.2 support to the github actions pipeline?

Nice one @fcoedno

@fernandoomarcelino
Copy link
Author

fernandoomarcelino commented Apr 4, 2023 •
edited
Loading

Could you add php 8.2 support to the github actions pipeline?

done. please take a look @fcoedno

Improve php dependencies support
e2c4f91 
* Add PHP 8.2 support
@thirsch
Copy link

thirsch commented May 1, 2023

LGTM, and it already has l10 support. +1 from me

@DeepDiver1975
Copy link

Any chance to get this merge and released? Much appreciated! THX

thirsch
thirsch reviewed May 7, 2023
View reviewed changes
composer.json
@@ -8,10 +8,10 @@
}
],
"require": {
"php": "^8.0 || ^8.1",
"php": "^8.0 || ^8.1 || ^8.2",
Copy link

@thirsch thirsch May 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for adding ^8.2, as ^8.0 already covers everything below 9.0. The same is true for the already existing ^8.1 of course. ;)

@DeepDiver1975
Copy link

@rjfonseca @roquerodrigo @gabrielferreiraa @pauloedurezende Can we get this merged and a new version tagged for packagist? Or do you consider this package abandoned?

Please let us know - THX a lot!

stevekamanke
stevekamanke reviewed Jun 18, 2023
View reviewed changes
Copy link

@stevekamanke stevekamanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeepDiver1975
Copy link

Thanks for approving this! Who is brave enough to hit the merge button? 🙈

@thirsch
Copy link

thirsch commented Jul 6, 2023

@fernandoomarcelino could you please rebase the branch? The l10 pr git merged first and therefore this branch contains conflicts now.

@DeepDiver1975
Copy link

can be closed due to #39

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thirsch thirsch thirsch approved these changes

@stevekamanke stevekamanke stevekamanke approved these changes

@xico42 xico42 xico42 approved these changes

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@diniz-victor diniz-victor diniz-victor left review comments

@roquerodrigo roquerodrigo Awaiting requested review from roquerodrigo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fernandoomarcelino @xico42 @diniz-victor @thirsch @DeepDiver1975 @stevekamanke