Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : Add .leaves() to MerkleTree #155

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix : Add .leaves() to MerkleTree #155

wants to merge 3 commits into from

Conversation

mahmudsudo
Copy link

Description

Add .leaves() to MerkleTree and appropriate test

closes: #144

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Re-reviewed Files changed in the Github PR explorer

@mahmudsudo mahmudsudo requested a review from a team as a code owner October 28, 2024 12:19
@mahmudsudo mahmudsudo requested review from mmagician, weikengchen and tyshko-rostyslav and removed request for a team October 28, 2024 12:19
@mmagician
Copy link
Member

@mahmudsudo it seems the unit test is broken.

@mahmudsudo
Copy link
Author

@mmagician can you please review again ?

@mmagician
Copy link
Member

@Pratyush the test here is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush approved these changes

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

@tyshko-rostyslav tyshko-rostyslav Awaiting requested review from tyshko-rostyslav tyshko-rostyslav is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add .leaves() to MerkleTree
3 participants
@mahmudsudo @mmagician @Pratyush