Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply rename migration to example users: IfWrapper -> hal #24

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Apply rename migration to example users: IfWrapper -> hal #24

merged 2 commits into from
Jul 24, 2023

Conversation

sksat
Copy link
Member

@sksat sksat commented Jul 21, 2023

概要

IfWrapper -> hal への migration を Example user に適用した

Issue / PR

詳細

詳しく

検証結果

test へのリンクや，検証結果へのリンク

影響範囲

XX系の動作がガラッと変わる，とか．

補足

何かあれば

@sksat sksat added enhancement New feature or request priority::high priorityg high tools labels Jul 21, 2023
@sksat sksat requested a review from meltingrabbit July 21, 2023 13:50
@sksat sksat self-assigned this Jul 21, 2023
@sksat
Copy link
Member Author

sksat commented Jul 21, 2023

とりあえず mobc だけ

@sksat
Copy link
Member Author

sksat commented Jul 21, 2023

rebase

@sksat sksat force-pushed the feature/rename-ifwrapper-examples branch from d1f9701 to 7724e0e Compare July 21, 2023 13:58
@sksat
Copy link
Member Author

sksat commented Jul 21, 2023

subobc 追加

@sksat
Copy link
Member Author

sksat commented Jul 21, 2023

あー，GitHub 調子悪いな

@sksat sksat force-pushed the feature/rename-ifwrapper-examples branch from 4625236 to b1ee003 Compare July 24, 2023 01:46
@meltingrabbit
Copy link
Member

よさそう．

ここでの PR のスコープ外な話で恐縮なんだけど，

SILS_SIC_IF_TX とかの IF ってどうしていくんだろうね？
if list の IF と合わせて整理かな？

@meltingrabbit meltingrabbit mentioned this pull request Jul 24, 2023
Merged
@sksat
Copy link
Member Author

sksat commented Jul 24, 2023

if_list とそこの整理は依存関係無いですね．やるとしても整理（ないし deprecate）は v4 とは別のタイミングですね．必要性が無いので．

meltingrabbit
meltingrabbit approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とてもよさそう

Base automatically changed from feature/rename-ifwrapper to develop July 24, 2023 07:12
@sksat
Copy link
Member Author

sksat commented Jul 24, 2023

#21 に続けてマージ

@sksat sksat merged commit 6c89eb9 into develop Jul 24, 2023
@sksat sksat deleted the feature/rename-ifwrapper-examples branch July 24, 2023 07:13
@meltingrabbit meltingrabbit mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltingrabbit meltingrabbit meltingrabbit approved these changes

Assignees

@sksat sksat

Labels
enhancement New feature or request priority::high priorityg high tools
Projects
C2A public
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sksat @meltingrabbit