Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply rename migration to example users: DriverSuper -> Framing #116

Closed

Conversation

sksat
Copy link
Member

@sksat sksat commented Oct 5, 2023

概要

DriverSuper -> Framing の migration を example user に適用した

Issue / PR

検証結果

CI が通ればよし

影響範囲

example user の DriverSuper 関係のものが rename される

@sksat sksat added enhancement New feature or request priority::high priorityg high labels Oct 5, 2023
@sksat sksat self-assigned this Oct 5, 2023
@sksat sksat marked this pull request as ready for review October 5, 2023 12:55
@sksat sksat force-pushed the feature/rename-driver-super-examples branch from 60ae11b to 30e67c5 Compare October 5, 2023 13:01
@sksat sksat force-pushed the feature/rename-driver-super branch from 3a6c49f to 8e3d336 Compare October 5, 2023 13:15
@sksat sksat force-pushed the feature/rename-driver-super-examples branch from 30e67c5 to 744b051 Compare October 5, 2023 13:16
@sksat sksat force-pushed the feature/rename-driver-super-examples branch from 9acea1e to 9852596 Compare October 5, 2023 13:31
@sksat sksat force-pushed the feature/rename-driver-super-examples branch from 9852596 to dc257a0 Compare October 5, 2023 13:38
@sksat sksat changed the title Apply rename migration to example users: DriverSuper -> Framing Pre Release (v4.0.0-beta.2): Apply rename migration to example users: DriverSuper -> Framing Oct 5, 2023
@meltingrabbit
Copy link
Member

beta リリースうちたい気持ちってなんでですか?

@sksat
Copy link
Member Author

sksat commented Oct 10, 2023

単に大きな breaking change だからです

@meltingrabbit meltingrabbit force-pushed the feature/rename-driver-super-examples branch from 0eb9fa0 to dc257a0 Compare October 10, 2023 13:50
@@ -64,7 +64,7 @@ struct AOBC_Driver
{
struct
{
DriverSuper super; //!< DriverSuper class
Framing super; //!< Framing class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Framing super; //!< Framing class
Framing framing; //!< Framing class

{
uint8_t i, stream;

for (i = 0; i < GS_PORT_TYPE_NUM; ++i)
{
DriverSuper* ds;
Framing* ds;
Copy link
Member

@meltingrabbit meltingrabbit Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Framing* ds;
Framing* frm;

@@ -67,14 +67,14 @@ typedef struct
// CCSDS 側の Driver
struct
{
DriverSuper super;
Framing super;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Framing super;
Framing framing;

CCSDS_Config ccsds_config;
} driver_ccsds;

// UART 側の Driver
struct
{
DriverSuper super;
Framing super;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Framing super;
Framing framing;

@sksat sksat changed the title Pre Release (v4.0.0-beta.2): Apply rename migration to example users: DriverSuper -> Framing Pre Release (v4.0.0-beta.3): Apply rename migration to example users: DriverSuper -> Framing Oct 10, 2023
@sksat sksat changed the title Pre Release (v4.0.0-beta.3): Apply rename migration to example users: DriverSuper -> Framing Apply rename migration to example users: DriverSuper -> Framing Oct 12, 2023
@sksat sksat marked this pull request as draft October 12, 2023 09:25
@sksat sksat removed the priority::high priorityg high label Oct 12, 2023
@sksat
Copy link
Member Author

sksat commented Oct 13, 2023

Drivers ディレクトリの構造の整理は #122, #124 でやった.framing ライブラリの分割は v4.0.0 より後に #145 でやっていくため,閉じ

@sksat sksat closed this Oct 13, 2023
@sksat sksat deleted the feature/rename-driver-super-examples branch October 13, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants