-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a new parser #151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamthome
force-pushed
the
feat/template-parser
branch
2 times, most recently
from
July 8, 2024 17:05
c2551ce
to
dbeb313
Compare
paulo-ferraz-oliveira
previously approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending minor comments. Feel free to resolve to move forward:
- they're not super-relevant
- we already have a task to further look at the interface (Define which functions, types, ... are the interface #102)
😄
Good stuff, @williamthome. |
I'm putting this PR into draft. I'll change types to opaque and add support functions for them. |
williamthome
force-pushed
the
feat/template-parser
branch
from
July 8, 2024 20:25
30c8b92
to
570dd3b
Compare
williamthome
force-pushed
the
feat/template-parser
branch
from
July 8, 2024 20:26
570dd3b
to
413eb60
Compare
I'll keep types not opaque to keep going on. |
paulo-ferraz-oliveira
approved these changes
Jul 8, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a new parser called
arizona_template_parser
. It will replacearizona_tpl_parse
.I believe this PR's new module is enough for now. We "tokenize" the template using the
arizona_template_scanner
and organize it into "elements" using thearizona_template_parser
. These elements are expected by the compiler to generate a "compiled" tree, i.e., the return of thearizona_live_view
render callback is the return of thearizona_template_parser
.Closes #144.
Depends on #143.It has been merged.