Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(eos_cli_config_gen): Restructure eos_cli_config_gen host vars for daemon_terminattr #4723

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Nov 14, 2024

Change Summary

Refactor eos_cli_config_gen host vars for daemon_terminattr.

Related Issue(s)

Fixes #https://github.com/aristanetworks/avd-internal/issues/171

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Refactor eos_cli_config_gen host vars for daemon_terminattr.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4723
# Activate the virtual environment
source test-avd-pr-4723/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/molecule-3#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/molecule-3 --force
# Optional: Install AVD examples
cd test-avd-pr-4723
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Nov 14, 2024
Copy link

sonarcloud bot commented Nov 14, 2024

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Nov 18, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review November 27, 2024 07:52
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners November 27, 2024 07:52
@MaheshGSLAB MaheshGSLAB changed the title CI(eos_cli_config_gen): Refactor eos_cli_config_gen host vars for daemon_terminattr CI(eos_cli_config_gen): Restructure eos_cli_config_gen host vars for daemon_terminattr Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants