-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI(eos_cli_config_gen): Restructure eos_cli_config_gen host vars for daemon_terminattr
#4723
Open
laxmikantchintakindi
wants to merge
2
commits into
aristanetworks:devel
Choose a base branch
from
laxmikantchintakindi:refactor/molecule-3
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CI(eos_cli_config_gen): Restructure eos_cli_config_gen host vars for daemon_terminattr
#4723
laxmikantchintakindi
wants to merge
2
commits into
aristanetworks:devel
from
laxmikantchintakindi:refactor/molecule-3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4723
# Activate the virtual environment
source test-avd-pr-4723/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/molecule-3#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/molecule-3 --force
# Optional: Install AVD examples
cd test-avd-pr-4723
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Nov 14, 2024
Quality Gate passedIssues Measures |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
MaheshGSLAB
reviewed
Nov 22, 2024
.../arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/terminattr-prem-no-ingestkey.yml
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
refactor/molecule-3
branch
from
November 22, 2024 08:00
d3b4337
to
4bde2af
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
laxmikantchintakindi
force-pushed
the
refactor/molecule-3
branch
from
November 25, 2024 13:55
8943438
to
2e2c9b8
Compare
Vibhu-gslab
force-pushed
the
refactor/molecule-3
branch
from
November 27, 2024 07:20
2e2c9b8
to
087e698
Compare
Vibhu-gslab
approved these changes
Nov 27, 2024
MaheshGSLAB
approved these changes
Nov 27, 2024
MaheshGSLAB
changed the title
CI(eos_cli_config_gen): Refactor eos_cli_config_gen host vars for
CI(eos_cli_config_gen): Restructure eos_cli_config_gen host vars for Nov 27, 2024
daemon_terminattr
daemon_terminattr
Vibhu-gslab
force-pushed
the
refactor/molecule-3
branch
from
November 28, 2024 05:27
087e698
to
46ef552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactor eos_cli_config_gen host vars for
daemon_terminattr
.Related Issue(s)
Fixes #https://github.com/aristanetworks/avd-internal/issues/171
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Refactor eos_cli_config_gen host vars for
daemon_terminattr
.How to test
Checklist
User Checklist
Repository Checklist