remove leftover offset property from instant

ariebovenberg · Jul 16, 2024 · de664e7 · de664e7
1 parent 730faaf
commit de664e7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,11 +1,11 @@
 🚀 Changelog
 ============
 
-0.6.4 (2024-07-??)
-------------------
+Development
+-----------
 
 - Add ``patch_current_time`` helper for patching the current time in tests
-- Remove undocumented ``year``/``month``/``day`` properties from ``Instant``
+- Remove undocumented ``year``/``month``/``day``/``offset`` properties from ``Instant``
 
 0.6.3 (2024-07-13)
 ------------------

diff --git a/src/lib.rs b/src/lib.rs
@@ -364,17 +364,6 @@ unsafe extern "C" fn module_exec(module: *mut PyObject) -> c_int {
         unpickle_system_datetime
     );
 
-    // XXX: this SEEMS to work out refcount- and GC-wise
-    PyDict_SetItemString(
-        (*state.instant_type).tp_dict,
-        c"offset".as_ptr(),
-        steal!(unwrap_or_errcode!(PyDict_GetItemString(
-            (*state.time_delta_type).tp_dict,
-            c"ZERO".as_ptr()
-        )
-        .as_result())),
-    );
-
     let zoneinfo_module = PyImport_ImportModule(c"zoneinfo".as_ptr());
     defer_decref!(zoneinfo_module);
     state.zoneinfo_type = PyObject_GetAttrString(zoneinfo_module, c"ZoneInfo".as_ptr());