-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch benches to hzkg/bn254 #292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!gpu-benchmark |
adr1anh
previously approved these changes
Feb 2, 2024
Note to self: investigating #281, and keeping the pasta benches at hand for that reason: it's easier if I have direct access to the same benches as those that showed the difference in speed betw. GPU/GPU-less. |
storojs72
previously approved these changes
Feb 12, 2024
!benchmark --features cuda,asm |
Now that I have the data for a branch that does not have any calls to the MSM in the IPA (which shows no change), I'm comfortable merging this. |
mpenciak
approved these changes
Feb 14, 2024
storojs72
approved these changes
Feb 14, 2024
Benchmark for 4cc09c8Click to view benchmark
|
adr1anh
approved these changes
Feb 14, 2024
mpenciak
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #278