Organize public param creation with assorted structs #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Major changes in the handling of the Commitment Key object across several files, moving from direct references to using the Arc (Atomic Reference Counting) mechanism for improved thread-safety and efficient sharing of data. - Removed the `Abomonation` trait from several structures, such as `ProverKey` and `VerifierKey`. - Introduced the `SimpleDigestible` trait to VerifierKey in several files, allowing them to be converted into a digestible form for hashing or storage. - Numerous updates in test cases and instances to reflect the shift from direct Commitment Key references to Arc. - Refactoring of the `setup` and `prove` methods in multiple files to handle the Arc type for Commitment Key. - Removal of several `abomonate_with` and `abomonation_skip` attribute annotations. - Enhancement of error details in multiple `assert` statements. - Added "rc" feature to the serde dependency in the Cargo.toml file. - Made comments on minimizing unnecessary data copies and keeping `setup` methods inexpensive.
- Extended functionality in `lib.rs` with new `PublicParams` structure, efficient abomonationwith `FlatPublicParams`, - Updated `mod.rs` for conditional feature `abomonate`, added `AuxParams` struct, and implemented conversions between `AuxParams` and `FlatAuxParams`. - demoed the new use of Abomonation in the minroot example
- Removed Abomonation dependency from several files.
winston-h-zhang
force-pushed
the
split-ck
branch
4 times, most recently
from
d143da9
to
aae2dcd
Compare
winston-h-zhang
force-pushed
the
split-ck
branch
from
aae2dcd
to
b480ad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Flat*structsinto_parts, which takes in 1) circuit shapes, 2) commitment keys, and 3) auxiliary data