add EnableDualStack option

[Hiroki6]

Related to argoproj/argo-workflows#13433

[agilgur5]

Thanks for taking a look and adding this option!

Could you please split the Go module changes into a separate PR? It's not related to this feature and is quite different.
It is also not necessary per my in-line comment as that line does not correspond to the version it compiles with and so may not be accepted/merged at all

[agilgur5]

Suggested change

	if opts.DisableDualStack {
	if !opts.EnableDualstack {

I would match the existing naming and capitalization of Minio's

[Hiroki6]

I did it intentionally since Minio enables it by default and if the client doesn't specify true in this field explicitly, it always disable it. But, if you think it's fine, I follow your suggestion

[agilgur5]

Per the Go docs, this is the minimum required Go version. Afaik, this repo does not use any newer Go features and so does not need to raise its version

That is also different from the version this compiles with or is linted with, which is listed in the GHA Workflows, e.g.

pkg/.github/workflows/go.yml

Line 19 in 42ec18a

go-version: 1.19

The consuming applications also set their own Go versions that compile this package. By definition, they must be at least as high as this go.mod version, which also makes this a breaking change

[Hiroki6]

sure, I reverted it

[agilgur5]

I am wondering if we should just inherit options here and parse a JSON blob in Argo Workflows's configuration of extraOpts. As this continues to expand and add to the spec. Allowing arbitrary options may make more sense.

cc @Joibel

[Hiroki6]

you mean like this?

type ExtraOpts struct {
	EnableDualStack bool
}

type S3ClientOpts struct {
        ...
	ExtraOpts       ExtraOpts
}