Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode Plugin Compatibility #67

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Entrox-Licher
Copy link
Contributor

Added minor check to add support for VSCode plugin by rolandostar

@Entrox-Licher
Copy link
Contributor Author

Let me know what I can do to help make the tests pass, since I'm unclear as to why they are failing

@argonui
Copy link
Owner

argonui commented Jul 10, 2024

Oof. Cleaning up stuff and saw this. Can you trigger a fresh check? Let's try and get new logs

@Entrox-Licher
Copy link
Contributor Author

Fresh logs generated @argonui

@argonui
Copy link
Owner

argonui commented Jul 31, 2024

ok, so some tests need to be updated. should be simple

I'm finding the errors on the checks tab: https://github.com/argonui/TTSModManager/pull/67/checks
i think these are most of them:
e2e_test.go:133
e2e_test.go:73
objects_test.go:490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants